From: sat <takeuchi_satoru@jp.fujitsu.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Rich Johnston <rjohnston@sgi.com>, xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices
Date: Tue, 20 Nov 2012 13:30:55 +0900 [thread overview]
Message-ID: <50AB077F.5000003@jp.fujitsu.com> (raw)
In-Reply-To: <50AB01AA.5060706@sandeen.net>
(2012/11/20 13:06), Eric Sandeen wrote:
> On 11/18/12 9:26 PM, sat wrote:
>> Hi Rich, Eric
>>
>> (2012/10/27 1:46), Rich Johnston wrote:
>>> On 06/08/2010 03:03 PM, Eric Sandeen wrote:
>>>> If you try running xfstests on lvm volumes which are symlinks,
>>>> it'll fail to run several tests because our _require_scratch
>>>> framework ultimately uses lstat not stat, and does not think
>>>> the lvm device (which is usually a symlink to a dm-X device)
>>>> is a block device. Sigh.
>>>>
>>>> Last try at this - just resolve any symlinked devicenames
>>>> into their realpath(3) in common.config.
>>>>
>>>> This actually seems to work.
>>>>
>>>> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
>>>>
>>>> ---
>>>>
>>>>
>>>> diff --git a/common.config b/common.config
>>>> index 926846b..e5b2483 100644
>>>> --- a/common.config
>>>> +++ b/common.config
>>>
>>> Looks good
>>>
>>> Reviewed-by: Rich Johnston <rjohnston@sgi.com>
>>>
>>> Eric,
>>>
>>> This patch has been committed to git://oss.sgi.com/xfs/cmds/xfstests, master branch, commit ID d5ea873f.
>>
>> From: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
>>
>> Commit d5ea873f is not the same as the the following original Eric's patch.
>>
>> http://oss.sgi.com/archives/xfs/2010-06/msg00080.html
>>
>> It does not modify src/Makefile and realpath is never compiled.
>
> Yep, whoops. Merge error . . .?
>
>> In addition, `[ -L $TEST_DEV ]' and `[ -L $SCRATCH_DEV ]' always returns 0
>> if $TEST_DEV or $SCRATCH_DEV are not defined.
>
> Well, I don't think ./check will get very far with an undefined TEST_DEV or
> SCRATCH_DEV, but better this way, thanks.
I think so too. But setting $SCRATCH_DEV is optional anyaway (refer to README).
I forgot to specify $SCRATCH_DEV and found this problem.
Satoru
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-20 4:29 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-06-08 20:03 [PATCH] xfstests: resolve symlinked devices to real paths Eric Sandeen
2012-10-26 16:46 ` Rich Johnston
2012-11-19 3:26 ` [PATCH] xfstests: fix to build src/realpath and the correct the existence of target devices sat
2012-11-19 3:55 ` Wanlong Gao
2012-11-20 4:06 ` Eric Sandeen
2012-11-20 4:30 ` sat [this message]
2012-11-20 5:28 ` Eric Sandeen
2012-11-20 13:53 ` Rich Johnston
2012-11-20 14:05 ` Eric Sandeen
[not found] <20121121135123.092349449@sgi.com>
2012-11-21 13:51 ` rjohnston
2012-11-21 14:31 ` Rich Johnston
2012-11-23 12:37 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB077F.5000003@jp.fujitsu.com \
--to=takeuchi_satoru@jp.fujitsu.com \
--cc=rjohnston@sgi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.