All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sasha Levin <sasha.levin@oracle.com>
To: Sasha Levin <sasha.levin@oracle.com>
Cc: peterz@infradead.org, mingo@redhat.com,
	linux-kernel@vger.kernel.org, penberg@kernel.org
Subject: Re: [PATCH] lockdep: be nice about building from userspace
Date: Tue, 20 Nov 2012 01:40:24 -0500	[thread overview]
Message-ID: <50AB25D8.4030203@oracle.com> (raw)
In-Reply-To: <1352753446-24109-1-git-send-email-sasha.levin@oracle.com>

Ping?

On 11/12/2012 03:50 PM, Sasha Levin wrote:
> Lockdep is an awesome piece of code which detects locking issues which are
> relevant both to userspace and kernelspace. We can easily make lockdep
> work in userspace since there is really no kernel spacific magic going
> on in the code.
> 
> All we need is to wrap two functions which are used by lockdep and are
> very kernel specific.
> 
> Doing that will allow tools located in tools/ to easily utilize lockdep's
> code for their own use.
> 
> Signed-off-by: Sasha Levin <sasha.levin@oracle.com>
> ---
>  kernel/lockdep.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/kernel/lockdep.c b/kernel/lockdep.c
> index 7981e5b..e898cfe 100644
> --- a/kernel/lockdep.c
> +++ b/kernel/lockdep.c
> @@ -584,6 +584,7 @@ static int very_verbose(struct lock_class *class)
>  /*
>   * Is this the address of a static object:
>   */
> +#ifdef __KERNEL__
>  static int static_obj(void *obj)
>  {
>  	unsigned long start = (unsigned long) &_stext,
> @@ -610,6 +611,7 @@ static int static_obj(void *obj)
>  	 */
>  	return is_module_address(addr) || is_module_percpu_address(addr);
>  }
> +#endif
>  
>  /*
>   * To make lock name printouts unique, we calculate a unique
> @@ -4109,6 +4111,7 @@ void debug_check_no_locks_held(struct task_struct *task)
>  		print_held_locks_bug(task);
>  }
>  
> +#ifdef __KERNEL__
>  void debug_show_all_locks(void)
>  {
>  	struct task_struct *g, *p;
> @@ -4166,6 +4169,7 @@ retry:
>  		read_unlock(&tasklist_lock);
>  }
>  EXPORT_SYMBOL_GPL(debug_show_all_locks);
> +#endif
>  
>  /*
>   * Careful: only use this function if you are sure that
> 


  reply	other threads:[~2012-11-20  6:41 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-12 20:50 [PATCH] lockdep: be nice about building from userspace Sasha Levin
2012-11-20  6:40 ` Sasha Levin [this message]
2012-12-13 18:42   ` Sasha Levin
2013-01-24 20:43 ` [tip:core/locking] lockdep: Be " tip-bot for Sasha Levin
2013-11-27 14:08 ` tip-bot for Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AB25D8.4030203@oracle.com \
    --to=sasha.levin@oracle.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=penberg@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.