From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Takai-0008VQ-ID for kexec@lists.infradead.org; Tue, 20 Nov 2012 09:58:06 +0000 Message-ID: <50AB53B8.1030309@cn.fujitsu.com> Date: Tue, 20 Nov 2012 17:56:08 +0800 From: zhangyanfei MIME-Version: 1.0 Subject: Re: [PATCH v4 0/2] x86: clear vmcss on all cpus when doing kdump if necessary References: <50A3645F.60302@cn.fujitsu.com> <50A611AA.6030903@cn.fujitsu.com> <20121120003258.GA1292@amt.cnet> In-Reply-To: <20121120003258.GA1292@amt.cnet> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Marcelo Tosatti Cc: "x86@kernel.org" , "kexec@lists.infradead.org" , Avi Kivity , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" 5LqOIDIwMTLlubQxMeaciDIw5pelIDA4OjMyLCBNYXJjZWxvIFRvc2F0dGkg5YaZ6YGTOgo+IE9u IEZyaSwgTm92IDE2LCAyMDEyIGF0IDA2OjEyOjU4UE0gKzA4MDAsIHpoYW5neWFuZmVpIHdyb3Rl Ogo+PiBIZWxsbyBNYXJjZWxvLAo+Pgo+PiBBbnkgdGhvdWdodHM/Cj4gCj4gSSB0aG91Z2h0IGEg ZnVuY3Rpb24gY2FsbCB3YXMgT0ssIGJ1dCBpdHMgYmV0dGVyIHRvIGhhdmUgYWxsIGNvZGUgaW4K PiB2bXguYy4gUGxlYXNlIGhhdmUgYW4gYXRvbWljIG5vdGlmaWVyIGluIGtleGVjLmMgKHJlZ2lz dGVyZWQgYnkgS1ZNCj4gbW9kdWxlIHZpYSBhdG9taWNfbm90aWZpZXJfY2hhaW5fcmVnaXN0ZXIg ZXRjKS4KPiAKPiBPdGhlciB0aGFuIHRoYXQsIHdoaWNoIGlzIGxhcmdlbHkgY29zbWV0aWMsIGl0 IGxvb2tzIGZpbmUuCj4gU29ycnkgZm9yIG5vdCBleHByZXNzaW5nIHRoaXMgZWFybGllci4KPiAK PiAKCkhtbSwgVGhhbmtzLiBJIHdpbGwgcmVzZW5kIGEgbmV3IHBhdGNoIHNldC4KClRoYW5rcwpa aGFuZwoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18Ka2V4 ZWMgbWFpbGluZyBsaXN0CmtleGVjQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmlu ZnJhZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9rZXhlYwo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: zhangyanfei Subject: Re: [PATCH v4 0/2] x86: clear vmcss on all cpus when doing kdump if necessary Date: Tue, 20 Nov 2012 17:56:08 +0800 Message-ID: <50AB53B8.1030309@cn.fujitsu.com> References: <50A3645F.60302@cn.fujitsu.com> <50A611AA.6030903@cn.fujitsu.com> <20121120003258.GA1292@amt.cnet> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: "x86@kernel.org" , "kexec@lists.infradead.org" , Avi Kivity , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" To: Marcelo Tosatti Return-path: In-Reply-To: <20121120003258.GA1292@amt.cnet> Sender: linux-kernel-owner@vger.kernel.org List-Id: kvm.vger.kernel.org =E4=BA=8E 2012=E5=B9=B411=E6=9C=8820=E6=97=A5 08:32, Marcelo Tosatti =E5= =86=99=E9=81=93: > On Fri, Nov 16, 2012 at 06:12:58PM +0800, zhangyanfei wrote: >> Hello Marcelo, >> >> Any thoughts? >=20 > I thought a function call was OK, but its better to have all code in > vmx.c. Please have an atomic notifier in kexec.c (registered by KVM > module via atomic_notifier_chain_register etc). >=20 > Other than that, which is largely cosmetic, it looks fine. > Sorry for not expressing this earlier. >=20 >=20 Hmm, Thanks. I will resend a new patch set. Thanks Zhang