All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <lrg@ti.com>
To: Mark Brown <broonie@opensource.wolfsonmicro.com>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH 1/4] ASoC: dapm: Standardise ASoC DAPM messages
Date: Tue, 20 Nov 2012 11:43:04 +0000	[thread overview]
Message-ID: <50AB6CC8.6080704@ti.com> (raw)
In-Reply-To: <20121120003108.GB4483@opensource.wolfsonmicro.com>

On 20/11/12 00:31, Mark Brown wrote:
> On Mon, Nov 19, 2012 at 02:39:12PM +0000, Liam Girdwood wrote:
>> Currently ASoC has a mixture of message prefixes e.g. "ASoC", "asoc"
>> or none and message types e.g. pr_debug or dev_dbg.
>>
>> Make sure all ASoC core messages use the same "ASoC" prefix and
>> convert any component device specific messages to use dev_dbg
>> instead of pr_debug.
>
> So, the reason we used to have the prefixes was that we didn't have dev_
> versions of the macros - I'd been going the other way and stripping out
> the prefixes for ASoC: because they seemed noisy and out of line with
> most other subsystems which either use dev_ or put a prefix in but not
> both.
>

Ok, my thinking here was that it was quite useful when debugging the new FW 
code. e.g. I knew if it was a core or driver related issue.

However, I'm easy on it going completely and I'll redo in favour of removing 
the pr_ and printk for device specific errors.

LLiam

  reply	other threads:[~2012-11-20 11:43 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-19 14:39 [PATCH 1/4] ASoC: dapm: Standardise ASoC DAPM messages Liam Girdwood
2012-11-19 14:39 ` [PATCH 2/4] ASoC: cache: Standardise ASoC cache messages Liam Girdwood
2012-11-19 14:39 ` [PATCH 3/4] ASoC: Jack: Standardise ASoC Jack messages Liam Girdwood
2012-11-19 14:39 ` [PATCH 4/4] ASoC: pcm: Standardise ASoC PCM messages Liam Girdwood
2012-11-20  0:31 ` [PATCH 1/4] ASoC: dapm: Standardise ASoC DAPM messages Mark Brown
2012-11-20 11:43   ` Liam Girdwood [this message]
2012-11-21  0:24     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50AB6CC8.6080704@ti.com \
    --to=lrg@ti.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@opensource.wolfsonmicro.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.