From: Hannes Reinecke <hare@suse.de>
To: Jayamohan Kallickal <Jayamohan.Kallickal@Emulex.Com>
Cc: SCSI Mailing List <linux-scsi@vger.kernel.org>
Subject: be_main.c:273 always evaluates to 'false'
Date: Tue, 20 Nov 2012 14:57:42 +0100 [thread overview]
Message-ID: <50AB8C56.7040604@suse.de> (raw)
Hi Jayamohan,
drivers/scsi/be2iscsi/be_main.c:273 has this statement:
if (abrt_task->sc->device->lun != abrt_task->sc->device->lun)
continue;
which is pointless at best, and actually harmful at worst as it
probably should compare with the scmd as passed to
beiscsi_eh_device_reset(struct scsi_cmnd *sc)
You might want to fix it up.
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
reply other threads:[~2012-11-20 13:57 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AB8C56.7040604@suse.de \
--to=hare@suse.de \
--cc=Jayamohan.Kallickal@Emulex.Com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.