From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexander Graf Subject: Re: [kvmarm] [RFC v4 8/8] oslib-posix: Align to permit transparent hugepages on ARM Linux Date: Tue, 20 Nov 2012 15:37:50 +0100 Message-ID: <50AB95BE.1090406@suse.de> References: <1353418270-23881-1-git-send-email-peter.maydell@linaro.org> <1353418270-23881-9-git-send-email-peter.maydell@linaro.org> <50AB8B95.8000106@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Peter Maydell , qemu-devel@nongnu.org, kvm@vger.kernel.org, patches@linaro.org, Marcelo Tosatti , kvmarm@lists.cs.columbia.edu, Blue Swirl , =?ISO-8859-1?Q?Andreas_F=E4rber?= To: Christoffer Dall Return-path: Received: from cantor2.suse.de ([195.135.220.15]:53640 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750993Ab2KTOhy (ORCPT ); Tue, 20 Nov 2012 09:37:54 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: On 11/20/2012 02:55 PM, Christoffer Dall wrote: > On Tue, Nov 20, 2012 at 8:54 AM, Alexander Graf wrote: >> On 11/20/2012 02:31 PM, Peter Maydell wrote: >>> ARM Linux (like x86-64 Linux) can use transparent hugepages for >>> KVM if memory blocks are 2MiB aligned; set QEMU_VMALLOC_ALIGN >>> accordingly. >>> >>> Signed-off-by: Peter Maydell >>> --- >>> oslib-posix.c | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/oslib-posix.c b/oslib-posix.c >>> index 9db9c3d..d25b52a 100644 >>> --- a/oslib-posix.c >>> +++ b/oslib-posix.c >>> @@ -35,7 +35,7 @@ >>> extern int daemon(int, int); >>> #endif >>> >>> -#if defined(__linux__)&& defined(__x86_64__) >>> +#if defined(__linux__)&& (defined(__x86_64__) || defined(__arm__)) >> >> Why not just drop the arch specific bit? >> >> > other archs have other alignment requirements, iirc. Ah, sorry, missed the rest of the lines around this one :). Yeah, should be ok then. Alex