From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCH 4/7] netprio_cgroup: reimplement priomap expansion Date: Tue, 20 Nov 2012 16:16:50 +0100 Message-ID: <50AB9EE2.6000709@monom.org> References: <1353400211-5182-1-git-send-email-tj@kernel.org> <1353400211-5182-5-git-send-email-tj@kernel.org> <50AB435E.8060901@monom.org> <20121120143832.GO15971@htj.dyndns.org> <50AB9D22.5030000@monom.org> <20121120151322.GR15971@htj.dyndns.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121120151322.GR15971-Gd/HAXX7CRxy/B6EtB590w@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-ID: Content-Type: text/plain; charset="us-ascii"; format="flowed" To: Tejun Heo Cc: serge.hallyn-Z7WLFzj8eWMS+FvcfC7Uqw@public.gmane.org, ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org, nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org, tgraf-G/eBtMaohhA@public.gmane.org, davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org, lizefan-hv44wF8Li93QT0dZR+AlfA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org On 20.11.2012 16:13, Tejun Heo wrote: > Hello, > > On Tue, Nov 20, 2012 at 04:09:22PM +0100, Daniel Wagner wrote: >> Thanks for the explanation. I was pondering if the new size in power >> of two could be a bit too excessive and the allocation step could be >> linear, e.g. stick at 4096. target_id will increase linear, >> therefore linear increase might also be enough, no? > > Well, power-of-two resizing tends to behave relatively well under most > cases and slab allocations are binned by power-of-two sizes, so > linearly growing it doesn't really buy anything. Convinced :) Tested and Acked-by: Daniel Wagner thanks, daniel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752965Ab2KTPQy (ORCPT ); Tue, 20 Nov 2012 10:16:54 -0500 Received: from hotel311.server4you.de ([85.25.146.15]:51662 "EHLO hotel311.server4you.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752336Ab2KTPQw (ORCPT ); Tue, 20 Nov 2012 10:16:52 -0500 Message-ID: <50AB9EE2.6000709@monom.org> Date: Tue, 20 Nov 2012 16:16:50 +0100 From: Daniel Wagner User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:15.0) Gecko/20120911 Thunderbird/15.0.1 MIME-Version: 1.0 To: Tejun Heo CC: serge.hallyn@canonical.com, ebiederm@xmission.com, nhorman@tuxdriver.com, tgraf@suug.ch, davem@davemloft.net, lizefan@huawei.com, cgroups@vger.kernel.org, containers@lists.linux-foundation.org, linux-kernel@vger.kernel.org, netdev@vger.kernel.org Subject: Re: [PATCH 4/7] netprio_cgroup: reimplement priomap expansion References: <1353400211-5182-1-git-send-email-tj@kernel.org> <1353400211-5182-5-git-send-email-tj@kernel.org> <50AB435E.8060901@monom.org> <20121120143832.GO15971@htj.dyndns.org> <50AB9D22.5030000@monom.org> <20121120151322.GR15971@htj.dyndns.org> In-Reply-To: <20121120151322.GR15971@htj.dyndns.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 20.11.2012 16:13, Tejun Heo wrote: > Hello, > > On Tue, Nov 20, 2012 at 04:09:22PM +0100, Daniel Wagner wrote: >> Thanks for the explanation. I was pondering if the new size in power >> of two could be a bit too excessive and the allocation step could be >> linear, e.g. stick at 4096. target_id will increase linear, >> therefore linear increase might also be enough, no? > > Well, power-of-two resizing tends to behave relatively well under most > cases and slab allocations are binned by power-of-two sizes, so > linearly growing it doesn't really buy anything. Convinced :) Tested and Acked-by: Daniel Wagner thanks, daniel