From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Tue, 20 Nov 2012 18:06:00 +0100 Subject: [PATCH V4 5/5] arm: mvebu: Added SMP support for Armada XP In-Reply-To: <20121120170127.GE27765@mudshark.cambridge.arm.com> References: <1353357360-7242-1-git-send-email-gregory.clement@free-electrons.com> <1353357360-7242-6-git-send-email-gregory.clement@free-electrons.com> <20121120164058.GB27765@mudshark.cambridge.arm.com> <50ABB499.6090508@free-electrons.com> <20121120170127.GE27765@mudshark.cambridge.arm.com> Message-ID: <50ABB878.1040804@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/20/2012 06:01 PM, Will Deacon wrote: > On Tue, Nov 20, 2012 at 04:49:29PM +0000, Gregory CLEMENT wrote: >> On 11/20/2012 05:40 PM, Will Deacon wrote: >>> >>> ENTRY(armada_xp_secondary_startup) >>> ldr r0, =ARMADA_XP_CFB_BASE >>> mrc p15, 0, r1, c0, c0, 5 >>> and r1, r1, #0xF >>> adr lr, BSYM(secondary_startup) >>> >>> /* Fallthrough */ >>> >>> ENTRY(ll_set_cpu_coherent) >>> ... >>> ENDPROC(ll_set_cpu_coherent) >>> ENDPROC(armada_xp_secondary_startup) >>> >>> what do you think? >>> >> >> I prefer to keep them separate, as we can use coherency without SMP. >> That's why I create the coherency_ll.S file instead of putting everything >> in this file. > > Hmm, can you elaborate a bit more on coherency without SMP please? Do these > controls also affect IO coherency? I meant Hardware IO coherency which is the purpose on the other patch set: "Add hardware I/O coherency support for Armada 370/XP" > > Will > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH V4 5/5] arm: mvebu: Added SMP support for Armada XP Date: Tue, 20 Nov 2012 18:06:00 +0100 Message-ID: <50ABB878.1040804@free-electrons.com> References: <1353357360-7242-1-git-send-email-gregory.clement@free-electrons.com> <1353357360-7242-6-git-send-email-gregory.clement@free-electrons.com> <20121120164058.GB27765@mudshark.cambridge.arm.com> <50ABB499.6090508@free-electrons.com> <20121120170127.GE27765@mudshark.cambridge.arm.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121120170127.GE27765-MRww78TxoiP5vMa5CHWGZ34zcgK1vI+I0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Will Deacon Cc: Lior Amsalem , Andrew Lunn , Ike Pan , Nadav Haklai , Ian Molton , David Marlin , Yehuda Yitschak , Jani Monoses , Russell King , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , "jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , Ben Dooks , Mike Turquette , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On 11/20/2012 06:01 PM, Will Deacon wrote: > On Tue, Nov 20, 2012 at 04:49:29PM +0000, Gregory CLEMENT wrote: >> On 11/20/2012 05:40 PM, Will Deacon wrote: >>> >>> ENTRY(armada_xp_secondary_startup) >>> ldr r0, =ARMADA_XP_CFB_BASE >>> mrc p15, 0, r1, c0, c0, 5 >>> and r1, r1, #0xF >>> adr lr, BSYM(secondary_startup) >>> >>> /* Fallthrough */ >>> >>> ENTRY(ll_set_cpu_coherent) >>> ... >>> ENDPROC(ll_set_cpu_coherent) >>> ENDPROC(armada_xp_secondary_startup) >>> >>> what do you think? >>> >> >> I prefer to keep them separate, as we can use coherency without SMP. >> That's why I create the coherency_ll.S file instead of putting everything >> in this file. > > Hmm, can you elaborate a bit more on coherency without SMP please? Do these > controls also affect IO coherency? I meant Hardware IO coherency which is the purpose on the other patch set: "Add hardware I/O coherency support for Armada 370/XP" > > Will > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com