From mboxrd@z Thu Jan 1 00:00:00 1970 From: George Dunlap Subject: Re: [PATCH V3] X86/vMCE: handle broken page with regard to migration Date: Tue, 20 Nov 2012 17:23:18 +0000 Message-ID: <50ABBC86.6040701@eu.citrix.com> References: <446f6b9bfc89137e1aa0.1353117881@ljsromley.bj.intel.com> <20646.33684.410414.579210@mariner.uk.xensource.com> <1353318919.18229.7.camel@zakaz.uk.xensource.com> <50AA5061.7040103@eu.citrix.com> <1353344256.18229.129.camel@zakaz.uk.xensource.com> <50AB9CFE.7000003@eu.citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: "Liu, Jinsong" Cc: "xen-devel@lists.xensource.com" , Ian Jackson , Ian Campbell , "JBeulich@suse.com" List-Id: xen-devel@lists.xenproject.org On 20/11/12 17:08, Liu, Jinsong wrote: >> On the other hand, the whole situation is hopefully rare enough that >> maybe we can just do the simple correct thing, even if it's a tiny bit >> sub-optimal. In that case, assuming that spurious vMCEs aren't a >> problem (e.g., #1), I think we basically just need to see if the last >> iteration contains a broken page, and if so, send the guest a vMCE on >> resume. >> >> Thoughts? > > Yes, that's exactly V3 patch did. Right -- but you did it by adding an extra couple of loops, which made us wonder if there was a more efficient way to do the same thing. Now that we know *what* needs to be done, we're in a better position to think about other options. Let me take a look... -George