From: "Frédéric Dalleau" <frederic.dalleau@linux.intel.com>
To: Gustavo Padovan <gustavo@padovan.org>, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH 2/2] Bluetooth: Implement deferred sco socket setup
Date: Tue, 20 Nov 2012 19:08:07 +0100 [thread overview]
Message-ID: <50ABC707.4040200@linux.intel.com> (raw)
In-Reply-To: <20121120180114.GJ14006@joana>
Hi,
On 11/20/2012 07:01 PM, Gustavo Padovan wrote:
> * Frédéric Dalleau <frederic.dalleau@linux.intel.com> [2012-11-20 18:55:39 +0100]:
>
>> Hi Gustavo,
>>
>> I'm taking your remarks into account asap
>>
>> On 11/20/2012 06:37 PM, Gustavo Padovan wrote:
>>> Where do you set sk_state to BT_CONNECTED. Doesn't it need to be here?
>> The state is set to BT_CONNECTED in hci_sync_conn_complete_evt. ie when
>> the connection is effectively created.
>
> Are we both talking about the sk_state var? I failed to see how it is set to
> BT_CONNECTED.
Yes, hci_sync_conn_complete_evt > hci_proto_connect_cfm > sco_connect_cfm >
if there is no error, sco_conn_ready.
Since the socket is already created we get in first if branch.
Frédéric
next prev parent reply other threads:[~2012-11-20 18:08 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 16:35 [PATCH 0/2] sco: BT_DEFER_SETUP for SCO sockets Frédéric Dalleau
2012-11-19 16:35 ` [PATCH 1/2] Bluetooth: Add BT_DEFER_SETUP option to sco socket Frédéric Dalleau
2012-11-19 16:35 ` [PATCH 2/2] Bluetooth: Implement deferred sco socket setup Frédéric Dalleau
2012-11-20 17:37 ` Gustavo Padovan
2012-11-20 17:55 ` Frédéric Dalleau
2012-11-20 18:01 ` Gustavo Padovan
2012-11-20 18:08 ` Frédéric Dalleau [this message]
2012-11-19 20:19 ` [PATCH 0/2] sco: BT_DEFER_SETUP for SCO sockets Gustavo Padovan
2012-11-20 10:39 ` Frédéric Dalleau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ABC707.4040200@linux.intel.com \
--to=frederic.dalleau@linux.intel.com \
--cc=gustavo@padovan.org \
--cc=linux-bluetooth@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.