From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [143.182.124.37]) by yocto-www.yoctoproject.org (Postfix) with ESMTP id 9E72AE01423 for ; Tue, 20 Nov 2012 14:19:45 -0800 (PST) Received: from azsmga002.ch.intel.com ([10.2.17.35]) by azsmga102.ch.intel.com with ESMTP; 20 Nov 2012 14:19:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.83,288,1352102400"; d="scan'208";a="170738357" Received: from unknown (HELO envy.home) ([10.255.12.178]) by AZSMGA002.ch.intel.com with ESMTP; 20 Nov 2012 14:19:41 -0800 Message-ID: <50AC01FD.7090104@linux.intel.com> Date: Tue, 20 Nov 2012 14:19:41 -0800 From: Darren Hart User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/20121029 Thunderbird/16.0.2 MIME-Version: 1.0 To: Constantin Musca References: <1353328788-31664-1-git-send-email-constantinx.musca@intel.com> In-Reply-To: <1353328788-31664-1-git-send-email-constantinx.musca@intel.com> X-Enigmail-Version: 1.4.6 Cc: poky@yoctoproject.org Subject: Re: [PATCH] poky-tiny.conf: blacklist inappropriate image options X-BeenThere: poky@yoctoproject.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: Poky build system developer discussion & patch submission for meta-yocto List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 20 Nov 2012 22:19:45 -0000 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Hi Constantin, On 11/19/2012 04:39 AM, Constantin Musca wrote: > Blacklist all images that aren't core-image-minimal-* > This needs a description as to what the problem is and why this change is needed. Note that the bug is here for reference, but cannot be relied upon to provide context. That is what the git log is for. I believe the core-image-rt image should also build, but I haven't tried recently. trace-cmd might break that. What sort of error is the user presented with when trying to build one of the blacklisted images? As I've stated in the bug, I'd be happier with an image whitelist than a blacklist as it is hopelessly unmaintainable. Have we explored the whitelist approach? Finally, please remember to CC the maintainer of the files you are modifying when that information is obvious. It is also good practice to CC the active bugzilla commenters when available. Thanks, Darren > [YOCTO #2565] > > Signed-off-by: Constantin Musca > --- > meta-yocto/conf/distro/poky-tiny.conf | 17 +++++++++++++++++ > 1 file changed, 17 insertions(+) > > diff --git a/meta-yocto/conf/distro/poky-tiny.conf b/meta-yocto/conf/distro/poky-tiny.conf > index d40748e..121534e 100644 > --- a/meta-yocto/conf/distro/poky-tiny.conf > +++ b/meta-yocto/conf/distro/poky-tiny.conf > @@ -120,3 +120,20 @@ MACHINE_ESSENTIAL_EXTRA_RDEPENDS = "" > # will build perl in case this package is installed. Since we don't care about > # this script for the purposes of tiny, remove the dependency from here. > RDEPENDS_${PN}-mtrace_pn-eglibc = "" > + > +INHERIT_DISTRO += "blacklist" > +PNBLACKLIST[build-appliance-image] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-base] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-basic] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-clutter] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-gtk-directfb] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-lsb] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-lsb-dev] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-lsb-sdk] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-rt] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-rt-sdk] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-sato] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-sato-dev] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-sato-sdk] = "not buildable with poky-tiny" > +PNBLACKLIST[core-image-x11] = "not buildable with poky-tiny" > +PNBLACKLIST[qt4e-demo-image] = "not buildable with poky-tiny" > -- Darren Hart Intel Open Source Technology Center Yocto Project - Technical Lead - Linux Kernel