From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Priebe - Profihost AG Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int Date: Wed, 21 Nov 2012 09:33:08 +0100 Message-ID: <50AC91C4.4070900@profihost.ag> References: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> <20121120162922.GA8665@stefanha-thinkpad.redhat.com> <50ABD713.3050300@profihost.ag> <50AC8704.2020407@profihost.ag> <20121121082616.GB13504@stefanha-thinkpad.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121121082616.GB13504-lxVrvc10SDTaErKTczak/Dh473NlOPsLVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: pve-devel-bounces-KmHT29P9Uc/4CZzEM2C48g@public.gmane.org Errors-To: pve-devel-bounces-KmHT29P9Uc/4CZzEM2C48g@public.gmane.org To: Stefan Hajnoczi Cc: Paolo Bonzini , ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, qemu-devel , pve-devel-KmHT29P9Uc/4CZzEM2C48g@public.gmane.org, josh.durgin-4GqslpFJ+cxBDgjK7y7TUQ@public.gmane.org List-Id: ceph-devel.vger.kernel.org Am 21.11.2012 09:26, schrieb Stefan Hajnoczi: > On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: >> Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: > We're going in circles here. I know the types are wrong in the code and > your patch fixes it, that's why I said it looks good in my first reply. Sorry not so familiar with processes like these. > QEMU is currently in hard freeze and only critical patches should go in. > Providing steps to reproduce the bug helps me decide that this patch > should still be merged for QEMU 1.3-rc1. > > Anyway, the patch is straightforward, I have applied it to my block tree > and it will be in QEMU 1.3-rc1: > https://github.com/stefanha/qemu/commits/block Thanks! The steps to reproduce are: mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends a discard. Important is that you use scsi-hd and set discard_granularity=512. Otherwise rbd disabled discard support. Might you have a look at my other rbd fix too? It fixes a race between task cancellation and writes. The same race was fixed in iscsi this summer. Greets, Stefan From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:51051) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb5kJ-0001dW-9S for qemu-devel@nongnu.org; Wed, 21 Nov 2012 03:33:27 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Tb5kD-00087K-Cl for qemu-devel@nongnu.org; Wed, 21 Nov 2012 03:33:23 -0500 Received: from mail.profihost.ag ([85.158.179.208]:41712) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Tb5kD-00083Z-30 for qemu-devel@nongnu.org; Wed, 21 Nov 2012 03:33:17 -0500 Message-ID: <50AC91C4.4070900@profihost.ag> Date: Wed, 21 Nov 2012 09:33:08 +0100 From: Stefan Priebe - Profihost AG MIME-Version: 1.0 References: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> <20121120162922.GA8665@stefanha-thinkpad.redhat.com> <50ABD713.3050300@profihost.ag> <50AC8704.2020407@profihost.ag> <20121121082616.GB13504@stefanha-thinkpad.redhat.com> In-Reply-To: <20121121082616.GB13504@stefanha-thinkpad.redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: Paolo Bonzini , ceph-devel@vger.kernel.org, qemu-devel , pve-devel@pve.proxmox.com, josh.durgin@inktank.com Am 21.11.2012 09:26, schrieb Stefan Hajnoczi: > On Wed, Nov 21, 2012 at 08:47:16AM +0100, Stefan Priebe - Profihost AG wrote: >> Am 21.11.2012 07:41, schrieb Stefan Hajnoczi: > We're going in circles here. I know the types are wrong in the code and > your patch fixes it, that's why I said it looks good in my first reply. Sorry not so familiar with processes like these. > QEMU is currently in hard freeze and only critical patches should go in. > Providing steps to reproduce the bug helps me decide that this patch > should still be merged for QEMU 1.3-rc1. > > Anyway, the patch is straightforward, I have applied it to my block tree > and it will be in QEMU 1.3-rc1: > https://github.com/stefanha/qemu/commits/block Thanks! The steps to reproduce are: mkfs.xfs -f a whole device bigger than int in bytes. mkfs.xfs sends a discard. Important is that you use scsi-hd and set discard_granularity=512. Otherwise rbd disabled discard support. Might you have a look at my other rbd fix too? It fixes a race between task cancellation and writes. The same race was fixed in iscsi this summer. Greets, Stefan