Re: [PATCH 2/2] drm: exynos: compose and send avi and aui info frames

[김승우 <sw0312.kim@samsung.com>]

Hi Rahul,

Control part seems good, and my comment is below.

On 2012년 11월 10일 01:21, Rahul Sharma wrote:
> This patch adds code for composing AVI and AUI info frames
> and send them every VSYNC.
> 
> This patch is important for hdmi certification.
> 
> Signed-off-by: Fahad Kunnathadi <fahad.k@samsung.com>
> Signed-off-by: Shirish S <s.shirish@samsung.com>
> Signed-off-by: Rahul Sharma <rahul.sharma@samsung.com>
> ---
>  drivers/gpu/drm/exynos/exynos_hdmi.c |   97 +++++++++++++++++++++++++++++++++-
>  drivers/gpu/drm/exynos/exynos_hdmi.h |   23 ++++++++
>  drivers/gpu/drm/exynos/regs-hdmi.h   |   17 +++++-
>  3 files changed, 133 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/exynos/exynos_hdmi.c b/drivers/gpu/drm/exynos/exynos_hdmi.c
> index 2c115f8..bb8a045 100644
> --- a/drivers/gpu/drm/exynos/exynos_hdmi.c
> +++ b/drivers/gpu/drm/exynos/exynos_hdmi.c

<snip>

> @@ -1993,6 +2084,8 @@ static void hdmi_mode_set(void *ctx, void *mode)
>  
>  	DRM_DEBUG_KMS("[%d] %s\n", __LINE__, __func__);
>  
> +	hdata->cur_video_id = drm_match_cea_mode(mode);
> +

How do you think about using predefined cea video id in struct
hdmi_conf? drm_mode does not have cea video id, so drm_match_cea_mode()
compares only mode information. Considering this, IMHO, cea video id can
be embedded in struct hdmi_conf.

>  	conf_idx = hdmi_conf_index(hdata, mode);
>  	if (conf_idx >= 0)
>  		hdata->cur_conf = conf_idx;

<snip>

Thanks and Regards,
- Seung-Woo Kim

-- 
Seung-Woo Kim
Samsung Software R&D Center
--

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel