From mboxrd@z Thu Jan 1 00:00:00 1970 From: gregory.clement@free-electrons.com (Gregory CLEMENT) Date: Wed, 21 Nov 2012 13:31:36 +0100 Subject: [PATCH V5 5/5] arm: mvebu: Added SMP support for Armada XP In-Reply-To: <20121121122610.GM3290@n2100.arm.linux.org.uk> References: <1353446150-10088-1-git-send-email-gregory.clement@free-electrons.com> <1353446150-10088-6-git-send-email-gregory.clement@free-electrons.com> <20121121104132.GD11990@mudshark.cambridge.arm.com> <50ACC198.5030300@free-electrons.com> <20121121122251.GI11990@mudshark.cambridge.arm.com> <20121121122610.GM3290@n2100.arm.linux.org.uk> Message-ID: <50ACC9A8.9060409@free-electrons.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On 11/21/2012 01:26 PM, Russell King - ARM Linux wrote: > On Wed, Nov 21, 2012 at 12:22:51PM +0000, Will Deacon wrote: >> Sorry, my mistake (I was thinking on my feet) since secondary_startup is >> declared in a C file, right? How about: >> >> ldr lr, =secondary_startup >> b ll_set_cpu_coherent > > Why? Do we really want LR to be the _virtual_ address? No we don't, > because secondary_startup expects to be called with the MMU off. > > So I go back to my original comment. What's wrong with: > > bl ll_set_cpu_coherent > b secondary_startup > > ? Nothing wrong, it works perfectly. Whereas indeed the code proposed by Will didn't work very well. I will take Russell's suggestion. Thanks, > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com From mboxrd@z Thu Jan 1 00:00:00 1970 From: Gregory CLEMENT Subject: Re: [PATCH V5 5/5] arm: mvebu: Added SMP support for Armada XP Date: Wed, 21 Nov 2012 13:31:36 +0100 Message-ID: <50ACC9A8.9060409@free-electrons.com> References: <1353446150-10088-1-git-send-email-gregory.clement@free-electrons.com> <1353446150-10088-6-git-send-email-gregory.clement@free-electrons.com> <20121121104132.GD11990@mudshark.cambridge.arm.com> <50ACC198.5030300@free-electrons.com> <20121121122251.GI11990@mudshark.cambridge.arm.com> <20121121122610.GM3290@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20121121122610.GM3290-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: devicetree-discuss-bounces+gldd-devicetree-discuss=m.gmane.org-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org Sender: "devicetree-discuss" To: Russell King - ARM Linux Cc: Lior Amsalem , Andrew Lunn , Ike Pan , Will Deacon , Nadav Haklai , Ian Molton , David Marlin , Yehuda Yitschak , Jani Monoses , Mike Turquette , Tawfik Bayouk , Dan Frazier , Eran Ben-Avi , Leif Lindholm , Sebastian Hesselbarth , Jason Cooper , "jcm-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org" , "devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org" , "rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org" , Ben Dooks , "linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" List-Id: devicetree@vger.kernel.org On 11/21/2012 01:26 PM, Russell King - ARM Linux wrote: > On Wed, Nov 21, 2012 at 12:22:51PM +0000, Will Deacon wrote: >> Sorry, my mistake (I was thinking on my feet) since secondary_startup is >> declared in a C file, right? How about: >> >> ldr lr, =secondary_startup >> b ll_set_cpu_coherent > > Why? Do we really want LR to be the _virtual_ address? No we don't, > because secondary_startup expects to be called with the MMU off. > > So I go back to my original comment. What's wrong with: > > bl ll_set_cpu_coherent > b secondary_startup > > ? Nothing wrong, it works perfectly. Whereas indeed the code proposed by Will didn't work very well. I will take Russell's suggestion. Thanks, > -- Gregory Clement, Free Electrons Kernel, drivers, real-time and embedded Linux development, consulting, training and support. http://free-electrons.com