All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robherring2@gmail.com>
To: Bongkyu Kim <bongkyu.kim@lge.com>
Cc: grant.likely@secretlab.ca, devicetree-discuss@lists.ozlabs.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] of/i2c: check status property for i2c client
Date: Wed, 21 Nov 2012 07:42:36 -0600	[thread overview]
Message-ID: <50ACDA4C.2030900@gmail.com> (raw)
In-Reply-To: <1353488270-14723-1-git-send-email-bongkyu.kim@lge.com>

On 11/21/2012 02:57 AM, Bongkyu Kim wrote:
> Because of_i2c_register_devices() do not check status property,
> all i2c clients are registered.
> 
> This patch add checking status property for i2c client.
> After this patch, if status property is absent or "okay" or "ok",
> i2c client will be registered.
> 
> Signed-off-by: Bongkyu Kim <bongkyu.kim@lge.com>

Applied.

> ---
>  drivers/of/of_i2c.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/of/of_i2c.c b/drivers/of/of_i2c.c
> index 3550f3b..2552fc5 100644
> --- a/drivers/of/of_i2c.c
> +++ b/drivers/of/of_i2c.c
> @@ -37,6 +37,9 @@ void of_i2c_register_devices(struct i2c_adapter *adap)
>  
>  		dev_dbg(&adap->dev, "of_i2c: register %s\n", node->full_name);
>  
> +		if (!of_device_is_available(node))
> +			continue;
> +
>  		if (of_modalias_node(node, info.type, sizeof(info.type)) < 0) {
>  			dev_err(&adap->dev, "of_i2c: modalias failure on %s\n",
>  				node->full_name);
> 

      reply	other threads:[~2012-11-21 13:42 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-21  8:57 [PATCH] of/i2c: check status property for i2c client Bongkyu Kim
2012-11-21 13:42 ` Rob Herring [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50ACDA4C.2030900@gmail.com \
    --to=robherring2@gmail.com \
    --cc=bongkyu.kim@lge.com \
    --cc=devicetree-discuss@lists.ozlabs.org \
    --cc=grant.likely@secretlab.ca \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.