From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Oliver Hartkopp <socketcan@hartkopp.net>
Cc: Stephane Grosjean <s.grosjean@peak-system.com>,
"linux-can@vger.kernel.org" <linux-can@vger.kernel.org>
Subject: Re: peak_usb: timestamp issue
Date: Wed, 21 Nov 2012 16:58:45 +0100 [thread overview]
Message-ID: <50ACFA35.90804@pengutronix.de> (raw)
In-Reply-To: <50ACF47E.7010004@hartkopp.net>
[-- Attachment #1: Type: text/plain, Size: 1200 bytes --]
On 11/21/2012 04:34 PM, Oliver Hartkopp wrote:
> Hi Stephane,
>
> i was working with the PEAK USB adapter today and got the problem of different
> timestamps with 'candump -x -ta can0':
>
> Timestamps of received CAN frames looked like my system 'uptime'.
> Send CAN frames had the real system time.
>
> The problem is, that you insert the hardware timestamp of the PEAK USB
> adapters into skb->tstamp ...
>
> This is wrong. For hardware timestamps (RX/TX) there's a special handling in
> the Linux Kernel, see at
>
> linux/Documentation/networking/timestamping.txt
>
> For now i just removed the setting of your HW timestamps on my Linux box (see
> attached patch).
>
> Please fix the HW timestamp handling in your driver by supporting the HW
> timstamp API correctly.
Oliver can you prepare a proper patch, which removes the broken time
stamping, I'd like to get this into 3.7.
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Industrial Linux Solutions | Phone: +49-231-2826-924 |
Vertretung West/Dortmund | Fax: +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686 | http://www.pengutronix.de |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]
prev parent reply other threads:[~2012-11-21 15:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-21 15:34 peak_usb: timestamp issue Oliver Hartkopp
2012-11-21 15:58 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50ACFA35.90804@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=s.grosjean@peak-system.com \
--cc=socketcan@hartkopp.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.