From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Weil Subject: Re: [PATCH] use int64_t for return values from rbd instead of int Date: Wed, 21 Nov 2012 18:03:42 +0100 Message-ID: <50AD096E.9080002@weilnetz.de> References: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org To: Stefan Priebe Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, pve-devel@pve.proxmox.com, josh.durgin@inktank.com, pbonzini@redhat.com, ceph-devel@vger.kernel.org List-Id: ceph-devel.vger.kernel.org Am 20.11.2012 13:44, schrieb Stefan Priebe: > rbd / rados tends to return pretty often length of writes > or discarded blocks. These values might be bigger than int. > > Signed-off-by: Stefan Priebe > --- > block/rbd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/rbd.c b/block/rbd.c > index f57d0c6..6bf9c2e 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -69,7 +69,7 @@ typedef enum { > typedef struct RBDAIOCB { > BlockDriverAIOCB common; > QEMUBH *bh; > - int ret; > + int64_t ret; > QEMUIOVector *qiov; > char *bounce; > RBDAIOCmd cmd; > @@ -87,7 +87,7 @@ typedef struct RADOSCB { > int done; > int64_t size; > char *buf; > - int ret; > + int64_t ret; > } RADOSCB; > > #define RBD_FD_READ 0 Why do you use int64_t instead of off_t? If the value is related to file sizes, off_t would be a good choice. Stefan W. From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:54600) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbDiJ-000107-OY for qemu-devel@nongnu.org; Wed, 21 Nov 2012 12:03:57 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbDiE-0003yT-OZ for qemu-devel@nongnu.org; Wed, 21 Nov 2012 12:03:51 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:45363) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbDiE-0003xJ-Ga for qemu-devel@nongnu.org; Wed, 21 Nov 2012 12:03:46 -0500 Message-ID: <50AD096E.9080002@weilnetz.de> Date: Wed, 21 Nov 2012 18:03:42 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> In-Reply-To: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> Content-Type: text/plain; charset=ISO-8859-15; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Priebe Cc: Stefan Hajnoczi , qemu-devel@nongnu.org, pve-devel@pve.proxmox.com, josh.durgin@inktank.com, pbonzini@redhat.com, ceph-devel@vger.kernel.org Am 20.11.2012 13:44, schrieb Stefan Priebe: > rbd / rados tends to return pretty often length of writes > or discarded blocks. These values might be bigger than int. > > Signed-off-by: Stefan Priebe > --- > block/rbd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/block/rbd.c b/block/rbd.c > index f57d0c6..6bf9c2e 100644 > --- a/block/rbd.c > +++ b/block/rbd.c > @@ -69,7 +69,7 @@ typedef enum { > typedef struct RBDAIOCB { > BlockDriverAIOCB common; > QEMUBH *bh; > - int ret; > + int64_t ret; > QEMUIOVector *qiov; > char *bounce; > RBDAIOCmd cmd; > @@ -87,7 +87,7 @@ typedef struct RADOSCB { > int done; > int64_t size; > char *buf; > - int ret; > + int64_t ret; > } RADOSCB; > > #define RBD_FD_READ 0 Why do you use int64_t instead of off_t? If the value is related to file sizes, off_t would be a good choice. Stefan W.