Re: [PATCH] sata_highbank: use ATA_BUSY

[Sergei Shtylyov <sshtylyov@mvista.com>]

Hello.

On 11/01/2012 08:59 PM, Sergei Shtylyov wrote:

> ahci_highbank_hardreset() uses bare number for the BSY bit of the ATA status
> register, despite it is #define'd in <linux/ata.h>

> Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com>

> ---
> The patch is atop of the 'upstream' branch of libata-dev.git...

>  drivers/ata/sata_highbank.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

> Index: libata-dev/drivers/ata/sata_highbank.c
> ===================================================================
> --- libata-dev.orig/drivers/ata/sata_highbank.c
> +++ libata-dev/drivers/ata/sata_highbank.c
> @@ -213,7 +213,7 @@ static int ahci_highbank_hardreset(struc
>  
>  	/* clear D2H reception area to properly wait for D2H FIS */
>  	ata_tf_init(link->device, &tf);
> -	tf.command = 0x80;
> +	tf.command = ATA_BUSY;
>  	ata_tf_to_fis(&tf, 0, 0, d2h_fis);
>  
>  	do {

   Jeff, are you going to queue this one and earlier patches from me?

MBR, Sergei