From: "Andreas Färber" <andreas.faerber@web.de>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
Anthony Liguori <aliguori@us.ibm.com>,
qemu-devel@nongnu.org, patches@linaro.org
Subject: Re: [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X
Date: Thu, 22 Nov 2012 01:04:12 +0100 [thread overview]
Message-ID: <50AD6BFC.9090703@web.de> (raw)
In-Reply-To: <CAFEAcA8GfHaxD-4e6R1xvLLrJSWM3niDqpmTfz_A8URxee5tMg@mail.gmail.com>
Am 22.11.2012 00:19, schrieb Peter Maydell:
> On 17 November 2012 13:10, Peter Maydell <peter.maydell@linaro.org> wrote:
>> On 17 November 2012 13:02, Andreas Färber <andreas.faerber@web.de> wrote:
>>> Am 16.11.2012 17:37, schrieb Peter Maydell:
>>>> +if test "$(uname -s)" = "Darwin"; then
>>>> + # On MacOS X the standard supported system compiler is 'cc' (usually clang),
>>>> + # and 'gcc' is a legacy llvm-gcc which is rather elderly and best avoided.
>>>
>>> This comment strikes me as wrong in this generality. It should at least
>>> be qualified with OSX version numbers.
>>
>> How about "and if 'gcc' is not the same as 'cc' then it is a legacy llvm-gcc
>> which is rather elderly and best avoided" ? I'd rather not get into having
>> to research which versions of OSX shipped with which compiler as 'cc',
>> when really the point is that 'cc' will always give you whichever compiler
>> Apple thought was the best default for that version.
>
> Andreas: ping? are you happy with this suggested rephrasing?
Not quite... clang is a relatively new thing. On v10.5.8 ppc64 'cc' is a
symlink to a real (well, Apple-flavoured) 'gcc-4.0'.
What about "... (clang on recent systems) and 'gcc' may be a legacy
llvm-gcc ..."?
> Do you
> think this is 1.3 material? (now the static-stublib stuff is in it's
> less critical, but it still seems like the right idea...)
I wouldn't be opposed to taking the default change into 1.3 as long as
we can still override it to a specific compiler.
But then again there's the question of why not doing it on Linux as well
now that we seem to compile under clang, we have cc -> gcc-4.7 on
openSUSE 12.2. Among our supported platforms only Solaris comes to my
mind where cc might be an incompatible proprietary compiler.
Andreas
next prev parent reply other threads:[~2012-11-22 0:04 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-16 16:37 [Qemu-devel] [PATCH] configure: Default to 'cc', not 'gcc', on MacOS X Peter Maydell
2012-11-17 13:02 ` Andreas Färber
2012-11-17 13:10 ` Peter Maydell
2012-11-21 23:19 ` Peter Maydell
2012-11-22 0:04 ` Andreas Färber [this message]
2012-11-22 8:33 ` Peter Maydell
2012-11-22 8:38 ` Brad Smith
2012-11-22 8:41 ` Peter Maydell
2012-11-22 8:45 ` Brad Smith
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AD6BFC.9090703@web.de \
--to=andreas.faerber@web.de \
--cc=aliguori@us.ibm.com \
--cc=patches@linaro.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.