From mboxrd@z Thu Jan 1 00:00:00 1970 From: Chen Gang Subject: Re: [PATCH] net: ipv6: change %8s to %s for rt->dst.dev->name in seq_printf of rt6_info_route Date: Thu, 22 Nov 2012 10:52:01 +0800 Message-ID: <50AD9351.5020805@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=GB2312 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: David Miller , netdev To: Shan Wei , Eric Dumazet Return-path: Received: from intranet.asianux.com ([58.214.24.6]:39735 "EHLO intranet.asianux.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754836Ab2KVSkH (ORCPT ); Thu, 22 Nov 2012 13:40:07 -0500 Sender: netdev-owner@vger.kernel.org List-ID: Hi Shan Wei, Eric Dumazet is this patch integrated into main branch ? if need me for additional completion (such as: merge another 2 trivia= l patches into this patch, too) please tell me, I will do.=20 I understand you are working overtime, maybe no time for any minor an= d trivial patches. if surely it is, I think: you can modify these code manually, and obsolete these minor and tr= ivial patches which I provided. I do not mind whether mention me in another new patches (you can me= ntion me or not mention me, both are OK). since our goal is to provide contributes to outside, efficiently. regards gchen =D3=DA 2012=C4=EA11=D4=C205=C8=D5 11:02, Chen Gang =D0=B4=B5=C0: > > 1. not to send same patch triple times.=20 thanks, I shall notice, next time. (I shall 'believe' another members). > 2. config your email client,because tab is changed to space. > you can read Documentation/email-clients.txt. 1) thanks. I shall notice, next time. 2) now, I get gvim as extention editor for thounderbird 3) the patch is generated by `git format-patch -s --summary --stat` it use "' '\t" as head, I do not touch it, maybe it is correct. welcome any members to giving additional suggestions and completions. thanks the modified contents are below, -----------------------------------------------------------------------= ------------ the length of rt->dst.dev->name is 16 (IFNAMSIZ) in seq_printf, it is not suitable to use %8s for rt->dst.dev->name. so change it to %s, since each line has not been solid any more. additional information: %8s limit the width, not for the original string output length if name length is more than 8, it still can be fully displayed= =2E if name length is less than 8, the ' ' will be filled before n= ame. %.8s truly limit the original string output length (precision) Signed-off-by: Chen Gang --- net/ipv6/route.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/net/ipv6/route.c b/net/ipv6/route.c index c42650c..b60bc52 100644 --- a/net/ipv6/route.c +++ b/net/ipv6/route.c @@ -2835,7 +2835,7 @@ static int rt6_info_route(struct rt6_info *rt, vo= id *p_arg) } else { seq_puts(m, "00000000000000000000000000000000"); } - seq_printf(m, " %08x %08x %08x %08x %8s\n", + seq_printf(m, " %08x %08x %08x %08x %s\n", rt->rt6i_metric, atomic_read(&rt->dst.__refcnt), rt->dst.__use, rt->rt6i_flags, rt->dst.dev ? rt->dst.dev->name : "");