From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Priebe - Profihost AG Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int Date: Thu, 22 Nov 2012 10:08:24 +0100 Message-ID: <50ADEB88.2090100@profihost.ag> References: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> <50AD096E.9080002@weilnetz.de> <50ADE115.4060707@profihost.ag> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii"; Format="flowed" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: pve-devel-bounces-KmHT29P9Uc/4CZzEM2C48g@public.gmane.org Errors-To: pve-devel-bounces-KmHT29P9Uc/4CZzEM2C48g@public.gmane.org To: Peter Maydell Cc: Stefan Hajnoczi , Stefan Weil , qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org, pve-devel-KmHT29P9Uc/4CZzEM2C48g@public.gmane.org, pbonzini-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, josh.durgin-4GqslpFJ+cxBDgjK7y7TUQ@public.gmane.org, ceph-devel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: ceph-devel.vger.kernel.org Hello, i send a new patch using ssize_t. (Subject [PATCH] overflow of int ret: use ssize_t for ret) Stefan Am 22.11.2012 09:40, schrieb Peter Maydell: > On 22 November 2012 08:23, Stefan Priebe - Profihost AG > wrote: >> Am 21.11.2012 23:32, schrieb Peter Maydell: >>> Looking at the librbd API (which is what the size and ret >>> values come from), it uses size_t and ssize_t for these. >>> So I think probably ssize_t is the right type for ret >>> (and size) in our structs here. >> >> >> This sounds reasonable but does ssize_t support negative values? For error >> values. > > Yes, the first 's' in ssize_t means 'signed' and is the > difference between it and size_t. > > -- PMM > From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbSlw-0004Sa-Hk for qemu-devel@nongnu.org; Thu, 22 Nov 2012 04:08:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbSls-0003ru-Mf for qemu-devel@nongnu.org; Thu, 22 Nov 2012 04:08:36 -0500 Received: from mail.profihost.ag ([85.158.179.208]:55648) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbSls-0003ri-DN for qemu-devel@nongnu.org; Thu, 22 Nov 2012 04:08:32 -0500 Message-ID: <50ADEB88.2090100@profihost.ag> Date: Thu, 22 Nov 2012 10:08:24 +0100 From: Stefan Priebe - Profihost AG MIME-Version: 1.0 References: <1353415495-30561-1-git-send-email-s.priebe@profihost.ag> <50AD096E.9080002@weilnetz.de> <50ADE115.4060707@profihost.ag> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] use int64_t for return values from rbd instead of int List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Stefan Hajnoczi , Stefan Weil , qemu-devel@nongnu.org, pve-devel@pve.proxmox.com, pbonzini@redhat.com, josh.durgin@inktank.com, ceph-devel@vger.kernel.org Hello, i send a new patch using ssize_t. (Subject [PATCH] overflow of int ret: use ssize_t for ret) Stefan Am 22.11.2012 09:40, schrieb Peter Maydell: > On 22 November 2012 08:23, Stefan Priebe - Profihost AG > wrote: >> Am 21.11.2012 23:32, schrieb Peter Maydell: >>> Looking at the librbd API (which is what the size and ret >>> values come from), it uses size_t and ssize_t for these. >>> So I think probably ssize_t is the right type for ret >>> (and size) in our structs here. >> >> >> This sounds reasonable but does ssize_t support negative values? For error >> values. > > Yes, the first 's' in ssize_t means 'signed' and is the > difference between it and size_t. > > -- PMM >