Re: [PATCH] peak_usb: fix hwtstamp assignment

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1473 bytes --]

On 11/21/2012 10:43 PM, Oliver Hartkopp wrote:
> The skb->tstamp is set to the hardware timestamp when available in the USB
> urb message. This leads to user visible timestamps which contain the 'uptime'
> of the USB adapter - and not the usual system generated timestamp.
> 
> Fix this wrong assignment by applying the available hardware timestamp to the
> skb_shared_hwtstamps data structure - which is intended for this purpose.
> 
> Signed-off-by: Oliver Hartkopp <socketcan@hartkopp.net>
> 
> ---
> 
> Hello Marc, hello Stephane,
> 
> i think we would generally need to support a hwtstamp_ioctl() for CAN
> interfaces which are controlled with a struct hwtstamp_config in the future.
> 
> For now this patch fixes the current issue much better than a simple removal
> of the skb->tstamp assignment.

Sure, making it work correctly is better than removing the broken stuff.
But removing the broken code is better than having wrong code in the driver.

> I'm currently on a business trip and i accidentally missed to take two PEAK
> USB interfaces with me to test this patch. It's compile tested ...

:)

> So let's wait for an Acked-by from Stephane.

yep,
Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]