From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Anthony Liguori <aliguori@us.ibm.com>,
Igor Mitsyanko <i.mitsyanko@samsung.com>,
qemu-devel <qemu-devel@nongnu.org>,
Alexander Graf <agraf@suse.de>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Andreas Faerber <afaerber@suse.de>,
Einar Lueck <elelueck@de.ibm.com>
Subject: Re: [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine
Date: Thu, 22 Nov 2012 14:22:38 +0100 [thread overview]
Message-ID: <50AE271E.80709@de.ibm.com> (raw)
In-Reply-To: <87k3tdc0cc.fsf@blackfin.pond.sub.org>
On 22/11/12 13:02, Markus Armbruster wrote:
Thanks for the review, Stefan already applied the patch, though.
Is there anything that you really want to have a followup patch
besides this one?
> There's just one caller that passes IF_DEFAULT. We could change it to
> pass machine->block_default_type instead, and drop parameter
> block_default_type. Follow-up patch.
I will have a look on that.
Christian
next prev parent reply other threads:[~2012-11-22 13:23 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-20 14:30 [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine Christian Borntraeger
2012-11-20 14:49 ` Alexander Graf
2012-11-21 11:11 ` Christian Borntraeger
2012-11-21 12:07 ` Igor Mitsyanko
2012-11-21 12:35 ` Christian Borntraeger
2012-11-22 12:02 ` Markus Armbruster
2012-11-22 13:22 ` Christian Borntraeger [this message]
2012-11-22 14:05 ` Markus Armbruster
2012-11-22 20:02 ` [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface Christian Borntraeger
2012-11-22 20:02 ` [Qemu-devel] [PATCH 1/2] block: simply default_drive Christian Borntraeger
2012-11-22 20:02 ` [Qemu-devel] [PATCH 2/2] block: clarify comment about IF_IDE = 0 Christian Borntraeger
2012-11-23 14:19 ` [Qemu-devel] [PATCH 0/2] Followup patches regarding block default interface Stefan Hajnoczi
2012-11-23 15:10 ` Markus Armbruster
2012-11-23 16:23 ` Stefan Hajnoczi
2012-11-22 15:21 ` [Qemu-devel] [PATCHv3] Support default block interfaces per QEMUMachine Stefan Hajnoczi
2012-11-22 13:42 ` Markus Armbruster
2012-11-22 12:58 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AE271E.80709@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=afaerber@suse.de \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=armbru@redhat.com \
--cc=cornelia.huck@de.ibm.com \
--cc=elelueck@de.ibm.com \
--cc=i.mitsyanko@samsung.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.