Re: [can:for-davem 2/3] drivers/net/can/usb/kvaser_usb.c:431 kvaser_usb_send_simple_msg() error: doing dma on the stack ((null))

[Marc Kleine-Budde <mkl@pengutronix.de>]

[-- Attachment #1: Type: text/plain, Size: 1333 bytes --]

On 11/22/2012 03:46 PM, Olivier Sobrie wrote:
> Hi Marc,
> 
> Argh.
> 
> On Thu, Nov 22, 2012 at 02:05:30PM +0100, Marc Kleine-Budde wrote:
>> Hello Olivier,
>>
>> can you please ask on the usb mailinglist how to fix this problem (given
>> this isn't a false positive)
> 
> Ok I'll ask. By googling I found this which looks to be a similar problem
> fixed in another driver.
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux.git;a=commitdiff;h=32ec4576c3fb37316b1d11a04b220527822f3f0d
> 
> I assume I've to kmalloc the kvaser_msg I send through
> kvaser_usb_send_msg(). I'll ask to people of linux-usb to be sure.
> 
> By the way I installed smatch (which I never used) and ran the command
>  make CHECK="~/bin/smatch -p=kernel" C=1"
> in my kernel dir but I didn't get the error:
>   CHECK   drivers/net/can/usb/kvaser_usb.c
>   CC [M]  drivers/net/can/usb/kvaser_usb.o
> 
> Do I've to give a specific option to smatch to get this error?

I've not used smack either. Maybe Wu can give us some hints and/or links.

Marc
-- 
Pengutronix e.K.                  | Marc Kleine-Budde           |
Industrial Linux Solutions        | Phone: +49-231-2826-924     |
Vertretung West/Dortmund          | Fax:   +49-5121-206917-5555 |
Amtsgericht Hildesheim, HRA 2686  | http://www.pengutronix.de   |


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 261 bytes --]