From: Li Zhang <zhlcindy@linux.vnet.ibm.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Anthony Liguori <aliguori@us.ibm.com>,
Alexander Graf <agraf@suse.de>,
qemu-devel qemu-devel <qemu-devel@nongnu.org>,
Blue Swirl <blauwirbel@gmail.com>,
"qemu-ppc@nongnu.org List" <qemu-ppc@nongnu.org>,
"zhlcindy@gmail.com" <zhlcindy@gmail.com>,
Aurelien Jarno <aurelien@aurel32.net>
Subject: Re: [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb
Date: Fri, 23 Nov 2012 00:50:38 +0800 [thread overview]
Message-ID: <50AE57DE.2090407@linux.vnet.ibm.com> (raw)
In-Reply-To: <CAFEAcA_vCr9ahtOb+7WCapmWFU78MFq5_ULGrmZ8okjwOWhcXg@mail.gmail.com>
On 2012年11月23日 00:49, Peter Maydell wrote:
> On 22 November 2012 16:39, Peter Maydell <peter.maydell@linaro.org> wrote:
>> We use "-usb" to enable USB in this command line. That has
>> to continue to work, for back compatibility. I think your
>> code to try to support -usb is broken:
>> case QEMU_OPTION_usb:
>> machine_opts = qemu_opts_find(qemu_find_opts("machine"), 0);
>>
>> will return NULL if there are no user-set machine opts
>> at this point, so we never go on to try to set the usb
>> machine opt to true.
> Patch sent which fixes this bug.
Thanks for fixing that. :)
>
> -- PMM
>
--
Li Zhang
IBM China Linux Technology Centre
prev parent reply other threads:[~2012-11-22 16:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-22 16:18 [Qemu-devel] commit 094b287 "Add USB option in machine options" broke i386 -usb Peter Maydell
2012-11-22 16:34 ` Li Zhang
2012-11-22 16:39 ` Peter Maydell
2012-11-22 16:43 ` Li Zhang
2012-11-22 16:44 ` Alexander Graf
2012-11-22 16:48 ` Li Zhang
2012-11-22 16:49 ` Peter Maydell
2012-11-22 16:50 ` Li Zhang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AE57DE.2090407@linux.vnet.ibm.com \
--to=zhlcindy@linux.vnet.ibm.com \
--cc=agraf@suse.de \
--cc=aliguori@us.ibm.com \
--cc=aurelien@aurel32.net \
--cc=blauwirbel@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=zhlcindy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.