From mboxrd@z Thu Jan  1 00:00:00 1970
From: Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/mm: Comment the definitions of _mfn(),
 _gfn() &c
Date: Thu, 22 Nov 2012 17:17:03 +0000
Message-ID: <50AE5E0F.8070405@citrix.com>
References: <3ea68d29fd57988d7788.1353604221@whitby.uk.xensource.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
Return-path: <xen-devel-bounces@lists.xen.org>
In-Reply-To: <3ea68d29fd57988d7788.1353604221@whitby.uk.xensource.com>
List-Unsubscribe: <http://lists.xen.org/cgi-bin/mailman/options/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=unsubscribe>
List-Post: <mailto:xen-devel@lists.xen.org>
List-Help: <mailto:xen-devel-request@lists.xen.org?subject=help>
List-Subscribe: <http://lists.xen.org/cgi-bin/mailman/listinfo/xen-devel>,
	<mailto:xen-devel-request@lists.xen.org?subject=subscribe>
Sender: xen-devel-bounces@lists.xen.org
Errors-To: xen-devel-bounces@lists.xen.org
To: Tim Deegan <tim@xen.org>
Cc: "xen-devel@lists.xen.org" <xen-devel@lists.xen.org>
List-Id: xen-devel@lists.xenproject.org

On 22/11/12 17:10, Tim Deegan wrote:
> # HG changeset patch
> # User Tim Deegan <tim@xen.org>
> # Date 1353604092 0
> # Node ID 3ea68d29fd57988d7788450f25ad0cd84cbd2fb4
> # Parent  7b4449bdb980caee8efc498d5ea48f772331df2f
> x86/mm: Comment the definitions of _mfn(), _gfn() &c.
>
> It's not very easy to find them if you don't know to look for the
> TYPE_SAFE() macro.

Ah - fantastic.  I have certainly spent longer than was sensible looking
for these definitions.

Would it be possible/sensible to a quick

#ifndef gfn_t
#define gfn_t /* gfn_t defined around here */
#undef gfn_t
#endif

So the likes of cscope and tags will also pick them up?

~Andrew

>
> Signed-off-by: Tim Deegan <tim@xen.org>
>
> diff -r 7b4449bdb980 -r 3ea68d29fd57 xen/include/asm-x86/guest_pt.h
> --- a/xen/include/asm-x86/guest_pt.h	Thu Nov 22 10:47:58 2012 +0100
> +++ b/xen/include/asm-x86/guest_pt.h	Thu Nov 22 17:08:12 2012 +0000
> @@ -36,6 +36,7 @@
>  /* Type of the guest's frame numbers */
>  TYPE_SAFE(unsigned long,gfn)
>  #define PRI_gfn "05lx"
> +/* Grep fodder: gfn_t, _gfn() and gfn_x() are defined here */
>  
>  #define VALID_GFN(m) (m != INVALID_GFN)
>  
> diff -r 7b4449bdb980 -r 3ea68d29fd57 xen/include/asm-x86/mm.h
> --- a/xen/include/asm-x86/mm.h	Thu Nov 22 10:47:58 2012 +0100
> +++ b/xen/include/asm-x86/mm.h	Thu Nov 22 17:08:12 2012 +0000
> @@ -455,6 +455,7 @@ static inline _type _name##_x(_name##_t 
>  #endif
>  
>  TYPE_SAFE(unsigned long,mfn);
> +/* Grep fodder: mfn_t, _mfn() and mfn_x() are defined here */
>  
>  /* Macro for printk formats: use as printk("%"PRI_mfn"\n", mfn_x(foo)); */
>  #define PRI_mfn "05lx"
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel

-- 
Andrew Cooper - Dom0 Kernel Engineer, Citrix XenServer
T: +44 (0)1223 225 900, http://www.citrix.com