From: Laxman Dewangan <ldewangan@nvidia.com>
To: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Cc: "broonie@opensource.wolfsonmicro.com"
<broonie@opensource.wolfsonmicro.com>, "lrg@ti.com" <lrg@ti.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] regulator: max8973: add regulator driver support
Date: Fri, 23 Nov 2012 05:59:54 +0530 [thread overview]
Message-ID: <50AEC382.1090105@nvidia.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1211201027190.21420@axis700.grange>
On Tuesday 20 November 2012 03:12 PM, Guennadi Liakhovetski wrote:
> Hi Laxman
>
> On Tue, 20 Nov 2012, Laxman Dewangan wrote:
>
>>>
>>> Here you actually need an offset within your register address space, so,
>>> should be
>>>
>>> + max->lru_index[0] = pdata->dvs_def_state;
>>
>> Yaah, seems some issue if vout_base is not zero. But really dont require here
>> as MAX8973_VOUT is 0 in this case.
> I think cleanly differentiating between register addresses, offsets and
> indices is important.
>
Ok, I will push the patch. Seems same fixing is also require for
tps62360 regulator.
prev parent reply other threads:[~2012-11-23 0:30 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 1:28 [PATCH] regulator: max8973: add regulator driver support Laxman Dewangan
2012-11-19 8:03 ` Mark Brown
2012-11-19 10:52 ` Guennadi Liakhovetski
2012-11-20 0:43 ` Mark Brown
2012-11-20 7:55 ` Guennadi Liakhovetski
2012-11-20 8:08 ` Mark Brown
2012-11-20 8:23 ` Guennadi Liakhovetski
2012-11-20 8:32 ` Mark Brown
2012-11-20 1:54 ` Laxman Dewangan
2012-11-20 9:42 ` Guennadi Liakhovetski
2012-11-23 0:29 ` Laxman Dewangan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AEC382.1090105@nvidia.com \
--to=ldewangan@nvidia.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=g.liakhovetski@gmx.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lrg@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.