From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Alexander Graf <agraf@suse.de>
Cc: Heinz Graalfs <graalfs@linux.vnet.ibm.com>,
qemu-devel <qemu-devel@nongnu.org>,
Viktor Mihajlovski <mihajlov@linux.vnet.ibm.com>,
Jens Freimann <jfrei@linux.vnet.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
Einar Lueck <elelueck@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 2/3] s390: clear registers, psw and prefix at vcpu reset
Date: Fri, 23 Nov 2012 15:32:16 +0100 [thread overview]
Message-ID: <50AF88F0.5020209@de.ibm.com> (raw)
In-Reply-To: <FB2D8461-06A4-4649-9AE2-86984778D5CD@suse.de>
On 23/11/12 14:40, Alexander Graf wrote:
>
> On 23.11.2012, at 11:18, Jens Freimann wrote:
>
>> When resetting vcpus on s390/kvm we have to clear registers, psw
>> and prefix as described in the z/Architecture PoP, otherwise a
>> reboot won't work. IPL PSW and prefix are set later on by the
>> s390-ipl device reset code.
>>
>> Signed-off-by: Jens Freimann <jfrei@linux.vnet.ibm.com>
>> ---
>> target-s390x/kvm.c | 26 +++++++++++++++++++++++++-
>> 1 file changed, 25 insertions(+), 1 deletion(-)
>>
>> diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c
>> index 94de764..b1b791e 100644
>> --- a/target-s390x/kvm.c
>> +++ b/target-s390x/kvm.c
>
> This needs to go into generic vcpu reset code.
The kvm ioctl certainly not, no? (definitely necessary for kernels
without sync regs).
I guess you are talking about moving the register initialisation
into s390_cpu_reset (target-s390x/cpu.c). Right? Jens can you have
a look?
Christian
next prev parent reply other threads:[~2012-11-23 14:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 10:18 [Qemu-devel] [PATCH 0/3] s390: vcpu reset, -cpu ? and minor sclp fix Jens Freimann
2012-11-23 10:18 ` [Qemu-devel] [PATCH 1/3] S390: Basic CPU model support Jens Freimann
2012-11-23 15:25 ` Andreas Färber
2012-11-23 10:18 ` [Qemu-devel] [PATCH 2/3] s390: clear registers, psw and prefix at vcpu reset Jens Freimann
2012-11-23 13:40 ` Alexander Graf
2012-11-23 14:17 ` Jens Freimann
2012-11-23 14:32 ` Christian Borntraeger [this message]
2012-11-23 14:34 ` Alexander Graf
2012-11-23 14:52 ` Jens Freimann
2012-11-23 15:02 ` Peter Maydell
2012-11-23 15:13 ` Alexander Graf
2012-11-23 10:18 ` [Qemu-devel] [PATCH 3/3] sclp: Fix uninitialized var in handle_write_event_buf() Jens Freimann
2012-11-23 13:42 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50AF88F0.5020209@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=agraf@suse.de \
--cc=cornelia.huck@de.ibm.com \
--cc=elelueck@linux.vnet.ibm.com \
--cc=graalfs@linux.vnet.ibm.com \
--cc=jfrei@linux.vnet.ibm.com \
--cc=mihajlov@linux.vnet.ibm.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.