From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= Subject: Re: [Qemu-devel] [PATCH 1/1] Legacy qemu-kvm options have no argument Date: Fri, 23 Nov 2012 17:45:26 +0100 Message-ID: <50AFA826.6020605@suse.de> References: Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Anthony Liguori , qemu-devel@nongnu.org, kvm@vger.kernel.org, Bruce Rogers , Stefan Hajnoczi To: Marcelo Tosatti Return-path: Received: from cantor2.suse.de ([195.135.220.15]:52891 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755803Ab2KWQpa (ORCPT ); Fri, 23 Nov 2012 11:45:30 -0500 In-Reply-To: Sender: kvm-owner@vger.kernel.org List-ID: Am 23.11.2012 13:41, schrieb Marcelo Tosatti: > From: Bruce Rogers >=20 > The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-ir= qchip > should be marked as having no argument. >=20 > Signed-off-by: Bruce Rogers > Reviewed-by: Jan Kiszka Missing a Reviewed-by: Stefan Hajnoczi from earlier today. Andreas > Signed-off-by: Marcelo Tosatti > --- > qemu-options.hx | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/qemu-options.hx b/qemu-options.hx > index 9bb29d3..fbcf079 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode. > ETEXI > =20 > HXCOMM Deprecated by -machine accel=3Dtcg property > -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) > +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) > =20 > HXCOMM Deprecated by kvm-pit driver properties > -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinje= ction, > +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection, > "", QEMU_ARCH_I386) > =20 > HXCOMM Deprecated (ignored) > -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I38= 6) > +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386) > =20 > HXCOMM Deprecated by -machine kernel_irqchip=3Don|off property > -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_= ARCH_I386) > +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I= 386) > =20 > HXCOMM Deprecated (ignored) > DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL) >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrn= berg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:60091) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbwOK-0001r5-5l for qemu-devel@nongnu.org; Fri, 23 Nov 2012 11:46:18 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TbwOJ-0007zZ-2k for qemu-devel@nongnu.org; Fri, 23 Nov 2012 11:46:12 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52889 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TbwOI-0007ug-PF for qemu-devel@nongnu.org; Fri, 23 Nov 2012 11:46:10 -0500 Message-ID: <50AFA826.6020605@suse.de> Date: Fri, 23 Nov 2012 17:45:26 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: In-Reply-To: Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/1] Legacy qemu-kvm options have no argument List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Marcelo Tosatti Cc: Anthony Liguori , Stefan Hajnoczi , qemu-devel@nongnu.org, kvm@vger.kernel.org, Bruce Rogers Am 23.11.2012 13:41, schrieb Marcelo Tosatti: > From: Bruce Rogers >=20 > The options no-kvm, no-kvm-pit, no-kvm-pit-reinjection, and no-kvm-irqc= hip > should be marked as having no argument. >=20 > Signed-off-by: Bruce Rogers > Reviewed-by: Jan Kiszka Missing a Reviewed-by: Stefan Hajnoczi from earlier today. Andreas > Signed-off-by: Marcelo Tosatti > --- > qemu-options.hx | 8 ++++---- > 1 files changed, 4 insertions(+), 4 deletions(-) >=20 > diff --git a/qemu-options.hx b/qemu-options.hx > index 9bb29d3..fbcf079 100644 > --- a/qemu-options.hx > +++ b/qemu-options.hx > @@ -2918,17 +2918,17 @@ Enable FIPS 140-2 compliance mode. > ETEXI > =20 > HXCOMM Deprecated by -machine accel=3Dtcg property > -DEF("no-kvm", HAS_ARG, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) > +DEF("no-kvm", 0, QEMU_OPTION_no_kvm, "", QEMU_ARCH_I386) > =20 > HXCOMM Deprecated by kvm-pit driver properties > -DEF("no-kvm-pit-reinjection", HAS_ARG, QEMU_OPTION_no_kvm_pit_reinject= ion, > +DEF("no-kvm-pit-reinjection", 0, QEMU_OPTION_no_kvm_pit_reinjection, > "", QEMU_ARCH_I386) > =20 > HXCOMM Deprecated (ignored) > -DEF("no-kvm-pit", HAS_ARG, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386) > +DEF("no-kvm-pit", 0, QEMU_OPTION_no_kvm_pit, "", QEMU_ARCH_I386) > =20 > HXCOMM Deprecated by -machine kernel_irqchip=3Don|off property > -DEF("no-kvm-irqchip", HAS_ARG, QEMU_OPTION_no_kvm_irqchip, "", QEMU_AR= CH_I386) > +DEF("no-kvm-irqchip", 0, QEMU_OPTION_no_kvm_irqchip, "", QEMU_ARCH_I38= 6) > =20 > HXCOMM Deprecated (ignored) > DEF("tdf", 0, QEMU_OPTION_tdf,"", QEMU_ARCH_ALL) >=20 --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg