All of lore.kernel.org
 help / color / mirror / Atom feed
From: Libo Chen <chenlibo.3-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Serge E. Hallyn" <serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org>
Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org,
	"Eric W. Biederman"
	<ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org>
Subject: Re: [PATCH RFC 3/5] printk: modify printk interface for syslog_namespace
Date: Sat, 24 Nov 2012 19:22:03 +0800	[thread overview]
Message-ID: <50B0ADDB.4000303@gmail.com> (raw)

On 2012/11/22 1:49, Serge E. Hallyn wrote:

> I notice that you haven't made any changes to the struct cont.  I
> suspect this means that to-be-continued msgs from one ns can be
> erroneously mixed with another ns.
>
Yes, I confirmed this problem. There will be erroneously mixed with another ns.
Thank you very much.

> You said you don't mind putting the syslogns into the userns.  If
> there's no reason not to do that, then we should do so as it will
> remove a bunch of code (plus the use of a new CLONE flag) from your
> patch, and the new syslog(NEW_NS) command from mine.
>
I agree with you, both are removable.

> Now IMO the ideal place for syslog_ns would be in the devices ns,
> but that does not yet exist, and may never.  The bonus to that would
> be that the consoles sort of belong there.  I avoid this by not
> having consoles in child syslog namespaces.  You put the console in
> the ns.  I haven't looked closely enough to see if what you do is
> ok (will do so soon).
>
> WOuld you mind looking through my patch to see if it suffices for
> your needs?  Where it does not, patches would be greatly appreciated
> if simple enough.

follow your patch, I can see inject message by "dmesg call" in container, is right?
I am worry that I debug  or see messages from serial ports console in some embedded system,
since console belongs to init_syslog,  so the message in container can`t be printed. 

> Note I'm not at all wedded to my patchset.  I'm happy to go with
> something else entirely.  My set was just a proof of concept.
>
>

             reply	other threads:[~2012-11-24 11:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-24 11:22 Libo Chen [this message]
     [not found] ` <50B0ADDB.4000303-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-25  4:28   ` [PATCH RFC 3/5] printk: modify printk interface for syslog_namespace Serge E. Hallyn
     [not found]     ` <20121125042802.GB4523-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2012-11-27 13:25       ` Libo Chen
     [not found]         ` <50B4BF64.6010707-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-27 13:58           ` Serge Hallyn
  -- strict thread matches above, loose matches on Subject: below --
2012-11-19  8:16 Rui Xiang
2012-11-19 14:29 ` Serge E. Hallyn
2012-11-19 14:53   ` Joe Perches
     [not found]   ` <20121119142926.GB4453-7LNsyQBKDXoIagZqoN9o3w@public.gmane.org>
2012-11-19 14:53     ` Joe Perches
2012-11-21  9:41     ` Rui Xiang
     [not found] ` <50A9EAF0.4000902-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2012-11-19 14:29   ` Serge E. Hallyn
2012-11-21 17:49   ` Serge E. Hallyn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B0ADDB.4000303@gmail.com \
    --to=chenlibo.3-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=containers-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org \
    --cc=ebiederm-aS9lmoZGLiVWk0Htik3J/w@public.gmane.org \
    --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=serge-A9i7LUbDfNHQT0dZR+AlfA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.