Re: [PATCH 3.7] spi/bcm63xx: fix transfer bits_per_words check

[Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>]

Le 24/11/2012 14:44, Jonas Gorski a écrit :
> Transfers often do not have bits_per_words set, so use the spi device's
> bits_per_words in this case.
>
> This fixes the driver rejecting valid transfers e.g. generated by
> spi_write() or spi_read().
>
> Cc: stable-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> Signed-off-by: Jonas Gorski <jonas.gorski-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>

Acked-by: Florian Fainelli <florian-p3rKhJxN3npAfugRpC6u6w@public.gmane.org>

> ---
>   drivers/spi/spi-bcm63xx.c |    3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/spi/spi-bcm63xx.c b/drivers/spi/spi-bcm63xx.c
> index a9f4049..d7c2916 100644
> --- a/drivers/spi/spi-bcm63xx.c
> +++ b/drivers/spi/spi-bcm63xx.c
> @@ -103,7 +103,8 @@ static int bcm63xx_spi_check_transfer(struct spi_device *spi,
>   {
>   	u8 bits_per_word;
>
> -	bits_per_word = (t) ? t->bits_per_word : spi->bits_per_word;
> +	bits_per_word = (t && t->bits_per_word) ?
> +			t->bits_per_word : spi->bits_per_word;
>   	if (bits_per_word != 8) {
>   		dev_err(&spi->dev, "%s, unsupported bits_per_word=%d\n",
>   			__func__, bits_per_word);
>


------------------------------------------------------------------------------
Monitor your physical, virtual and cloud infrastructure from a single
web console. Get in-depth insight into apps, servers, databases, vmware,
SAP, cloud infrastructure, etc. Download 30-day Free Trial.
Pricing starts from $795 for 25 servers or applications!
http://p.sf.net/sfu/zoho_dev2dev_nov