From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:42691)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TcOF0-0001EH-Jz
	for qemu-devel@nongnu.org; Sat, 24 Nov 2012 17:30:28 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TcOEz-0001Hz-2V
	for qemu-devel@nongnu.org; Sat, 24 Nov 2012 17:30:26 -0500
Received: from cantor2.suse.de ([195.135.220.15]:39510 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <afaerber@suse.de>) id 1TcOEy-0000t3-SF
	for qemu-devel@nongnu.org; Sat, 24 Nov 2012 17:30:24 -0500
Message-ID: <50B14A4F.2040405@suse.de>
Date: Sat, 24 Nov 2012 23:29:35 +0100
From: =?ISO-8859-15?Q?Andreas_F=E4rber?= <afaerber@suse.de>
MIME-Version: 1.0
References: <1353595852-30776-1-git-send-email-fred.konrad@greensocs.com>
	<1353595852-30776-2-git-send-email-fred.konrad@greensocs.com>
In-Reply-To: <1353595852-30776-2-git-send-email-fred.konrad@greensocs.com>
Content-Type: text/plain; charset=ISO-8859-15
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [RFC PATCH v2 1/3] virtio-bus : Introduce
	VirtioBus.
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: fred.konrad@greensocs.com
Cc: peter.maydell@linaro.org, aliguori@us.ibm.com, e.voevodin@samsung.com, mark.burton@greensocs.com, qemu-devel@nongnu.org, stefanha@redhat.com, cornelia.huck@de.ibm.com

Am 22.11.2012 15:50, schrieb fred.konrad@greensocs.com:
> diff --git a/hw/virtio-bus.c b/hw/virtio-bus.c
> new file mode 100644
> index 0000000..991b6f5
> --- /dev/null
> +++ b/hw/virtio-bus.c
[...]
> +#define DEBUG_VIRTIO_BUS 1

We probably want to disable debug output by default as done elsewhere?

> +
> +#define DPRINTF(fmt, ...) if (DEBUG_VIRTIO_BUS) {                     =
   \
> +                            printf("virtio_bus: " fmt , ## __VA_ARGS__=
); \
> +                          }
> +
> +static void virtio_bus_init_cb(VirtioBus *bus);
> +static int virtio_bus_reset(BusState *qbus);
> +
> +static void virtio_bus_class_init(ObjectClass *klass, void *data)
> +{
> +    BusClass *k =3D BUS_CLASS(klass);
> +    k->reset =3D virtio_bus_reset;
> +}
> +
> +static TypeInfo virtio_bus_info =3D {

Somehow you lost "const" here since v1.

> +    .name =3D TYPE_VIRTIO_BUS,
> +    .parent =3D TYPE_BUS,
> +    .instance_size =3D sizeof(VirtioBus),
> +    .class_init =3D virtio_bus_class_init,
> +};

The BUS()-related changes look good, thanks!

Andreas

--=20
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe=
rg