All of lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi@redhat.com>
To: Jan Kiszka <jan.kiszka@siemens.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, qemu-devel <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions
Date: Sun, 25 Nov 2012 12:18:59 +0200	[thread overview]
Message-ID: <50B1F093.80901@redhat.com> (raw)
In-Reply-To: <5097B302.3080203@siemens.com>

On 11/05/2012 02:37 PM, Jan Kiszka wrote:
>> 
>> As I noted, init and destroy cannot cause a topology update.
> 
> Ah, right. Why are we wrapping them in transaction_begin/commit at all then?
> 

We aren't.


void memory_region_destroy(MemoryRegion *mr)
{
    assert(QTAILQ_EMPTY(&mr->subregions));
    assert(memory_region_transaction_depth == 0);


-- 
error compiling committee.c: too many arguments to function

  reply	other threads:[~2012-11-25 10:19 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-04  8:30 [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions Jan Kiszka
2012-11-04 19:21 ` Avi Kivity
2012-11-05  6:26   ` Jan Kiszka
2012-11-05  8:12     ` Avi Kivity
2012-11-05  8:51       ` Jan Kiszka
2012-11-05 12:33         ` Avi Kivity
2012-11-05 12:37           ` Jan Kiszka
2012-11-25 10:18             ` Avi Kivity [this message]
2012-11-25 10:45               ` Jan Kiszka
2012-11-25 12:47                 ` Avi Kivity
2012-11-05 15:45 ` [Qemu-devel] [PATCH v2] " Jan Kiszka
2012-11-10 19:28   ` Blue Swirl

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B1F093.80901@redhat.com \
    --to=avi@redhat.com \
    --cc=blauwirbel@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.