From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:35521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TcZi3-0007O8-MH for qemu-devel@nongnu.org; Sun, 25 Nov 2012 05:45:12 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TcZi2-0000XI-Mu for qemu-devel@nongnu.org; Sun, 25 Nov 2012 05:45:11 -0500 Received: from mout.web.de ([212.227.15.4]:51106) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TcZi2-0000Wz-DL for qemu-devel@nongnu.org; Sun, 25 Nov 2012 05:45:10 -0500 Message-ID: <50B1F6B0.9040005@web.de> Date: Sun, 25 Nov 2012 11:45:04 +0100 From: Jan Kiszka MIME-Version: 1.0 References: <509627A2.3040509@web.de> <5096C044.7060504@redhat.com> <50975C27.5010906@web.de> <509774ED.6040104@redhat.com> <50977E1A.1070105@siemens.com> <5097B203.30207@redhat.com> <5097B302.3080203@siemens.com> <50B1F093.80901@redhat.com> In-Reply-To: <50B1F093.80901@redhat.com> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig44A4766A6B0B448A0FB83B54" Subject: Re: [Qemu-devel] [PATCH] memory: Reintroduce dirty flag to optimize changes on disabled regions List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Avi Kivity Cc: Blue Swirl , qemu-devel This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig44A4766A6B0B448A0FB83B54 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable On 2012-11-25 11:18, Avi Kivity wrote: > On 11/05/2012 02:37 PM, Jan Kiszka wrote: >>> >>> As I noted, init and destroy cannot cause a topology update. >> >> Ah, right. Why are we wrapping them in transaction_begin/commit at all= then? >> >=20 > We aren't. >=20 >=20 > void memory_region_destroy(MemoryRegion *mr) > { > assert(QTAILQ_EMPTY(&mr->subregions)); > assert(memory_region_transaction_depth =3D=3D 0); >=20 We were talking about address_space_init/destroy. Jan --------------enig44A4766A6B0B448A0FB83B54 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.16 (GNU/Linux) Comment: Using GnuPG with Mozilla - http://www.enigmail.net/ iEYEARECAAYFAlCx9rMACgkQitSsb3rl5xRiTwCfa/2SVw7FsIbaMt39vMauu3Rn kloAoNJlvZop3VsDgKymArsTeCHciDEW =S5YG -----END PGP SIGNATURE----- --------------enig44A4766A6B0B448A0FB83B54--