From: Stefan Priebe <s.priebe@profihost.ag>
To: Sage Weil <sage@inktank.com>
Cc: "ceph-devel@vger.kernel.org" <ceph-devel@vger.kernel.org>,
Alexandre DERUMIER <aderumier@odiso.com>
Subject: Re: syncfs via syscall doesn not work
Date: Sun, 25 Nov 2012 19:39:38 +0100 [thread overview]
Message-ID: <50B265EA.7050306@profihost.ag> (raw)
In-Reply-To: <alpine.DEB.2.00.1211241519580.23552@cobra.newdream.net>
Am 25.11.2012 00:20, schrieb Sage Weil:
> On Sat, 24 Nov 2012, Stefan Priebe wrote:
>> Am 24.11.2012 18:16, schrieb Sage Weil:
>>> On Sat, 24 Nov 2012, Stefan Priebe - Profihost AG wrote:
>>>> At the machine compiling? Yes!
>>>
>>> Hmm, I just tested on my wonky wheezy machine (glibc 2.13, 3.2) and
>>> system(SYS_syncfs, ..) works for me. But the #define is in libc6-dev:
>>
>> But that means your glibc supports it. Then we don't need the syscall at
>> all.
>>
>> To me it's only present in the kernel headers (linux-libc-dev) like
>> this:
>>
>> [pb64: ~]# grep -r syncfs /usr/include
>> /usr/include/asm/unistd_64.h:#define __NR_syncfs 306
>> /usr/include/asm/unistd_64.h:__SYSCALL(__NR_syncfs, sys_syncfs)
>> /usr/include/asm/unistd_32.h:#define __NR_syncfs 344
>> /usr/include/asm-generic/unistd.h:#define __NR_syncfs 267
>> /usr/include/asm-generic/unistd.h:__SYSCALL(__NR_syncfs, sys_syncfs)
>
> Can try wip-syncfs? It checks for either SYS_syncfs or __NR_syncfs.
Since your latest patch it looks good to me:
starting osd.11 at :/0 osd_data /ceph/osd.11/ /dev/sdb1
2012-11-25 19:37:15.686305 7f155e1db780 0 filestore(/ceph/osd.11/)
mount FIEMAP ioctl is supported and appears to work
2012-11-25 19:37:15.686313 7f155e1db780 0 filestore(/ceph/osd.11/)
mount FIEMAP ioctl is disabled via 'filestore fiemap' config option
2012-11-25 19:37:15.686500 7f155e1db780 0 filestore(/ceph/osd.11/)
mount did NOT detect btrfs
2012-11-25 19:37:15.687850 7f155e1db780 0 filestore(/ceph/osd.11/)
mount syscall(__NR_syncfs, fd) fully supported
2012-11-25 19:37:15.687899 7f155e1db780 0 filestore(/ceph/osd.11/)
mount found snaps <>
2012-11-25 19:37:15.689973 7f155e1db780 0 filestore(/ceph/osd.11/)
mount: enabling WRITEAHEAD journal mode: btrfs not detected
2012-11-25 19:37:15.700405 7f155e1db780 0 journal kernel version is 3.6.7
2012-11-25 19:37:15.710407 7f155e1db780 0 journal kernel version is 3.6.7
YES! No more need to build a custom patched glibc.
Stefan
prev parent reply other threads:[~2012-11-25 18:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-23 8:19 syncfs via syscall doesn not work Stefan Priebe - Profihost AG
2012-11-24 3:07 ` Sage Weil
2012-11-24 5:34 ` Stefan Priebe - Profihost AG
2012-11-24 17:16 ` Sage Weil
2012-11-24 20:24 ` Stefan Priebe
2012-11-24 23:20 ` Sage Weil
2012-11-25 18:39 ` Stefan Priebe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B265EA.7050306@profihost.ag \
--to=s.priebe@profihost.ag \
--cc=aderumier@odiso.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.