From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from [222.73.24.84] (helo=song.cn.fujitsu.com) by merlin.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1Tcnrk-0002uM-C1 for kexec@lists.infradead.org; Mon, 26 Nov 2012 01:52:09 +0000 Message-ID: <50B2CACD.2000103@cn.fujitsu.com> Date: Mon, 26 Nov 2012 09:50:05 +0800 From: Zhang Yanfei MIME-Version: 1.0 Subject: Re: [PATCH v8 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary References: <50ADE0C2.1000106@cn.fujitsu.com> <20121125142642.GC25516@redhat.com> In-Reply-To: <20121125142642.GC25516@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Gleb Natapov Cc: "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" , Marcelo Tosatti 5LqOIDIwMTLlubQxMeaciDI15pelIDIyOjI2LCBHbGViIE5hdGFwb3Yg5YaZ6YGTOgo+IE9uIFRo dSwgTm92IDIyLCAyMDEyIGF0IDA0OjIyOjI2UE0gKzA4MDAsIFpoYW5nIFlhbmZlaSB3cm90ZToK Pj4gQ3VycmVudGx5LCBrZHVtcCBqdXN0IG1ha2VzIGFsbCB0aGUgbG9naWNhbCBwcm9jZXNzb3Jz IGxlYXZlIFZNWCBvcGVyYXRpb24gYnkKPj4gZXhlY3V0aW5nIFZNWE9GRiBpbnN0cnVjdGlvbiwg c28gYW55IFZNQ1NzIGFjdGl2ZSBvbiB0aGUgbG9naWNhbCBwcm9jZXNzb3JzIG1heQo+PiBiZSBj b3JydXB0ZWQuIEJ1dCwgc29tZXRpbWVzLCB3ZSBuZWVkIHRoZSBWTUNTcyB0byBkZWJ1ZyBndWVz dCBpbWFnZXMgY29udGFpbmVkCj4+IGluIHRoZSBob3N0IHZtY29yZS4gVG8gcHJldmVudCB0aGUg Y29ycnVwdGlvbiwgd2Ugc2hvdWxkIFZNQ0xFQVIgdGhlIFZNQ1NzIGJlZm9yZQo+PiBleGVjdXRp bmcgdGhlIFZNWE9GRiBpbnN0cnVjdGlvbi4KPj4KPj4gVGhlIHBhdGNoIHNldCBwcm92aWRlcyBh IHdheSB0byBWTUNMRUFSIHZtY3NzIHJlbGF0ZWQgdG8gZ3Vlc3RzIG9uIGFsbCBjcHVzIGJlZm9y ZQo+PiBleGVjdXRpbmcgdGhlIFZNWE9GRiB3aGVuIGRvaW5nIGtkdW1wLiBUaGlzIGlzIHVzZWQg dG8gZW5zdXJlIHRoZSBWTUNTcyBpbiB0aGUKPj4gdm1jb3JlIHVwZGF0ZWQgYW5kIG5vbi1jb3Jy dXB0ZWQuCj4+Cj4gTG9va3MgZmluZSB0byBtZSwgYnV0IGtleGVjIHBhcnQgc2hvdWxkIGdldCBh Y2tzIGZyb20gZXhlYyBtYWludGFpbmVycy4KClRoYW5rcy4gSSB3aWxsIGFzayB0aGUgZXhlYyBt YWludGFpbmVyLgoKPiAKPj4gQ2hhbmdlbG9nIGZyb20gdjcgdG8gdjg6Cj4+IDEuIEtFWEVDOiBy ZWdyZXNzaW9uIGZvciB1c2luZyBuYW1lIGNyYXNoX25vdGlmaWVyX2xpc3QKPj4gICAgYW5kIHJl bW92ZSBjb21tZW50cyByZWxhdGVkIHRvIEtWTQo+PiAgICBhbmQganVzdCBjYWxsIGZ1bmN0aW9u IGF0b21pY19ub3RpZmllcl9jYWxsX2NoYWluIGRpcmVjdGx5Lgo+Pgo+PiBDaGFuZ2Vsb2cgZnJv bSB2NiB0byB2NzoKPj4gMS4gS1ZNLUlOVEVMOiBpbiBoYXJkd2FyZV9kaXNhYmxlLCB3ZSBuZWVk bid0IGRpc2FibGUgdGhlCj4+ICAgIHZtY2xlYXIsIHNvIHJlbW92ZSBpdC4KPj4KPj4gQ2hhbmdl bG9nIGZyb20gdjUgdG8gdjY6Cj4+IDEuIEtFWEVDOiB0aGUgYXRvbWljIG5vdGlmaWVyIGxpc3Qg cmVuYW1lZDoKPj4gICAgY3Jhc2hfbm90aWZpZXJfbGlzdCAtLT4gdm1jbGVhcl9ub3RpZmllcl9s aXN0Cj4+IDIuIEtWTS1JTlRFTDogcHJvdmlkZSBlbXB0eSBmdW5jdGlvbnMgaWYgQ09ORklHX0tF WEVDIGlzCj4+ICAgIG5vdCBkZWZpbmVkIGFuZCByZW1vdmUgdW5uZWNlc3NhcnkgI2lmZGVmJ3Mu Cj4+Cj4+IENoYW5nZWxvZyBmcm9tIHY0IHRvIHY1Ogo+PiAxLiB1c2UgYW4gYXRvbWljIG5vdGlm aWVyIGluc3RlYWQgb2YgZnVuY3Rpb24gY2FsbCwgc28KPj4gICAgaGF2ZSBhbGwgdGhlIHZtY2xl YXIgY29kZXMgaW4gdm14LmMuCj4+Cj4+IENoYW5nZWxvZyBmcm9tIHYzIHRvIHY0Ogo+PiAxLiBh ZGQgYSBuZXcgcGVyY3B1IHZhcmlhYmxlIHZtY2xlYXJfc2tpcHBlZCB0byBza2lwCj4+ICAgIHZt Y2xlYXIgaW4ga2R1bXAgaW4gc29tZSBjb25kaXRpb25zLgo+Pgo+PiBDaGFuZ2Vsb2cgZnJvbSB2 MiB0byB2MzoKPj4gMS4gcmVtb3ZlIHVubmVjZXNzYXJ5IGNvbmRpdGlvbnMgaW4gZnVuY3Rpb24K Pj4gICAgY3B1X2VtZXJnZW5jeV9jbGVhcl9sb2FkZWRfdm1jc3MgYXMgTWFyY2VsbyBzdWdnZXN0 ZWQuCj4+Cj4+IENoYW5nZWxvZyBmcm9tIHYxIHRvIHYyOgo+PiAxLiByZW1vdmUgdGhlIHN5c2N0 bCBhbmQgY2xlYXIgVk1DU3MgdW5jb25kaXRpb25hbGx5Lgo+Pgo+PiBaaGFuZyBZYW5mZWkgKDIp Ogo+PiAgIHg4Ni9rZXhlYzogYWRkIGEgbmV3IGF0b21pYyBub3RpZmllciBsaXN0IGZvciBrZHVt cAo+PiAgIEtWTS1JTlRFTDogYWRkIGEgbm90aWZpZXIgYW5kIGEgYml0bWFwIHRvIHN1cHBvcnQg Vk1DTEVBUiBpbiBrZHVtcAo+Pgo+PiAgYXJjaC94ODYvaW5jbHVkZS9hc20va2V4ZWMuaCB8ICAg IDIgKwo+PiAgYXJjaC94ODYva2VybmVsL2NyYXNoLmMgICAgICB8ICAgIDkgKysrKysKPj4gIGFy Y2gveDg2L2t2bS92bXguYyAgICAgICAgICAgfCAgIDcwICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+PiAgMyBmaWxlcyBjaGFuZ2VkLCA4MSBpbnNlcnRpb25zKCsp LCAwIGRlbGV0aW9ucygtKQo+IAo+IC0tCj4gCQkJR2xlYi4KPiAKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: Zhang Yanfei Subject: Re: [PATCH v8 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary Date: Mon, 26 Nov 2012 09:50:05 +0800 Message-ID: <50B2CACD.2000103@cn.fujitsu.com> References: <50ADE0C2.1000106@cn.fujitsu.com> <20121125142642.GC25516@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: "x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" , "kexec-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "kvm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Marcelo Tosatti To: Gleb Natapov Return-path: In-Reply-To: <20121125142642.GC25516-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kexec-bounces-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org Errors-To: kexec-bounces+glkk-kexec=m.gmane.org-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org List-Id: kvm.vger.kernel.org 5LqOIDIwMTLlubQxMeaciDI15pelIDIyOjI2LCBHbGViIE5hdGFwb3Yg5YaZ6YGTOgo+IE9uIFRo dSwgTm92IDIyLCAyMDEyIGF0IDA0OjIyOjI2UE0gKzA4MDAsIFpoYW5nIFlhbmZlaSB3cm90ZToK Pj4gQ3VycmVudGx5LCBrZHVtcCBqdXN0IG1ha2VzIGFsbCB0aGUgbG9naWNhbCBwcm9jZXNzb3Jz IGxlYXZlIFZNWCBvcGVyYXRpb24gYnkKPj4gZXhlY3V0aW5nIFZNWE9GRiBpbnN0cnVjdGlvbiwg c28gYW55IFZNQ1NzIGFjdGl2ZSBvbiB0aGUgbG9naWNhbCBwcm9jZXNzb3JzIG1heQo+PiBiZSBj b3JydXB0ZWQuIEJ1dCwgc29tZXRpbWVzLCB3ZSBuZWVkIHRoZSBWTUNTcyB0byBkZWJ1ZyBndWVz dCBpbWFnZXMgY29udGFpbmVkCj4+IGluIHRoZSBob3N0IHZtY29yZS4gVG8gcHJldmVudCB0aGUg Y29ycnVwdGlvbiwgd2Ugc2hvdWxkIFZNQ0xFQVIgdGhlIFZNQ1NzIGJlZm9yZQo+PiBleGVjdXRp bmcgdGhlIFZNWE9GRiBpbnN0cnVjdGlvbi4KPj4KPj4gVGhlIHBhdGNoIHNldCBwcm92aWRlcyBh IHdheSB0byBWTUNMRUFSIHZtY3NzIHJlbGF0ZWQgdG8gZ3Vlc3RzIG9uIGFsbCBjcHVzIGJlZm9y ZQo+PiBleGVjdXRpbmcgdGhlIFZNWE9GRiB3aGVuIGRvaW5nIGtkdW1wLiBUaGlzIGlzIHVzZWQg dG8gZW5zdXJlIHRoZSBWTUNTcyBpbiB0aGUKPj4gdm1jb3JlIHVwZGF0ZWQgYW5kIG5vbi1jb3Jy dXB0ZWQuCj4+Cj4gTG9va3MgZmluZSB0byBtZSwgYnV0IGtleGVjIHBhcnQgc2hvdWxkIGdldCBh Y2tzIGZyb20gZXhlYyBtYWludGFpbmVycy4KClRoYW5rcy4gSSB3aWxsIGFzayB0aGUgZXhlYyBt YWludGFpbmVyLgoKPiAKPj4gQ2hhbmdlbG9nIGZyb20gdjcgdG8gdjg6Cj4+IDEuIEtFWEVDOiBy ZWdyZXNzaW9uIGZvciB1c2luZyBuYW1lIGNyYXNoX25vdGlmaWVyX2xpc3QKPj4gICAgYW5kIHJl bW92ZSBjb21tZW50cyByZWxhdGVkIHRvIEtWTQo+PiAgICBhbmQganVzdCBjYWxsIGZ1bmN0aW9u IGF0b21pY19ub3RpZmllcl9jYWxsX2NoYWluIGRpcmVjdGx5Lgo+Pgo+PiBDaGFuZ2Vsb2cgZnJv bSB2NiB0byB2NzoKPj4gMS4gS1ZNLUlOVEVMOiBpbiBoYXJkd2FyZV9kaXNhYmxlLCB3ZSBuZWVk bid0IGRpc2FibGUgdGhlCj4+ICAgIHZtY2xlYXIsIHNvIHJlbW92ZSBpdC4KPj4KPj4gQ2hhbmdl bG9nIGZyb20gdjUgdG8gdjY6Cj4+IDEuIEtFWEVDOiB0aGUgYXRvbWljIG5vdGlmaWVyIGxpc3Qg cmVuYW1lZDoKPj4gICAgY3Jhc2hfbm90aWZpZXJfbGlzdCAtLT4gdm1jbGVhcl9ub3RpZmllcl9s aXN0Cj4+IDIuIEtWTS1JTlRFTDogcHJvdmlkZSBlbXB0eSBmdW5jdGlvbnMgaWYgQ09ORklHX0tF WEVDIGlzCj4+ICAgIG5vdCBkZWZpbmVkIGFuZCByZW1vdmUgdW5uZWNlc3NhcnkgI2lmZGVmJ3Mu Cj4+Cj4+IENoYW5nZWxvZyBmcm9tIHY0IHRvIHY1Ogo+PiAxLiB1c2UgYW4gYXRvbWljIG5vdGlm aWVyIGluc3RlYWQgb2YgZnVuY3Rpb24gY2FsbCwgc28KPj4gICAgaGF2ZSBhbGwgdGhlIHZtY2xl YXIgY29kZXMgaW4gdm14LmMuCj4+Cj4+IENoYW5nZWxvZyBmcm9tIHYzIHRvIHY0Ogo+PiAxLiBh ZGQgYSBuZXcgcGVyY3B1IHZhcmlhYmxlIHZtY2xlYXJfc2tpcHBlZCB0byBza2lwCj4+ICAgIHZt Y2xlYXIgaW4ga2R1bXAgaW4gc29tZSBjb25kaXRpb25zLgo+Pgo+PiBDaGFuZ2Vsb2cgZnJvbSB2 MiB0byB2MzoKPj4gMS4gcmVtb3ZlIHVubmVjZXNzYXJ5IGNvbmRpdGlvbnMgaW4gZnVuY3Rpb24K Pj4gICAgY3B1X2VtZXJnZW5jeV9jbGVhcl9sb2FkZWRfdm1jc3MgYXMgTWFyY2VsbyBzdWdnZXN0 ZWQuCj4+Cj4+IENoYW5nZWxvZyBmcm9tIHYxIHRvIHYyOgo+PiAxLiByZW1vdmUgdGhlIHN5c2N0 bCBhbmQgY2xlYXIgVk1DU3MgdW5jb25kaXRpb25hbGx5Lgo+Pgo+PiBaaGFuZyBZYW5mZWkgKDIp Ogo+PiAgIHg4Ni9rZXhlYzogYWRkIGEgbmV3IGF0b21pYyBub3RpZmllciBsaXN0IGZvciBrZHVt cAo+PiAgIEtWTS1JTlRFTDogYWRkIGEgbm90aWZpZXIgYW5kIGEgYml0bWFwIHRvIHN1cHBvcnQg Vk1DTEVBUiBpbiBrZHVtcAo+Pgo+PiAgYXJjaC94ODYvaW5jbHVkZS9hc20va2V4ZWMuaCB8ICAg IDIgKwo+PiAgYXJjaC94ODYva2VybmVsL2NyYXNoLmMgICAgICB8ICAgIDkgKysrKysKPj4gIGFy Y2gveDg2L2t2bS92bXguYyAgICAgICAgICAgfCAgIDcwICsrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKwo+PiAgMyBmaWxlcyBjaGFuZ2VkLCA4MSBpbnNlcnRpb25zKCsp LCAwIGRlbGV0aW9ucygtKQo+IAo+IC0tCj4gCQkJR2xlYi4KPiAKCgpfX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QKa2V4ZWNA bGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xp c3RpbmZvL2tleGVjCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753954Ab2KZBwE (ORCPT ); Sun, 25 Nov 2012 20:52:04 -0500 Received: from cn.fujitsu.com ([222.73.24.84]:6969 "EHLO song.cn.fujitsu.com" rhost-flags-OK-FAIL-OK-OK) by vger.kernel.org with ESMTP id S1753501Ab2KZBwC convert rfc822-to-8bit (ORCPT ); Sun, 25 Nov 2012 20:52:02 -0500 X-IronPort-AV: E=Sophos;i="4.83,317,1352044800"; d="scan'208";a="6272129" Message-ID: <50B2CACD.2000103@cn.fujitsu.com> Date: Mon, 26 Nov 2012 09:50:05 +0800 From: Zhang Yanfei User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.8) Gecko/20121012 Thunderbird/10.0.8 MIME-Version: 1.0 To: Gleb Natapov CC: "x86@kernel.org" , "kexec@lists.infradead.org" , Marcelo Tosatti , "linux-kernel@vger.kernel.org" , "kvm@vger.kernel.org" Subject: Re: [PATCH v8 0/2] x86: vmclear vmcss on all cpus when doing kdump if necessary References: <50ADE0C2.1000106@cn.fujitsu.com> <20121125142642.GC25516@redhat.com> In-Reply-To: <20121125142642.GC25516@redhat.com> X-MIMETrack: Itemize by SMTP Server on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/11/26 09:51:35, Serialize by Router on mailserver/fnst(Release 8.5.3|September 15, 2011) at 2012/11/26 09:51:37 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 于 2012年11月25日 22:26, Gleb Natapov 写道: > On Thu, Nov 22, 2012 at 04:22:26PM +0800, Zhang Yanfei wrote: >> Currently, kdump just makes all the logical processors leave VMX operation by >> executing VMXOFF instruction, so any VMCSs active on the logical processors may >> be corrupted. But, sometimes, we need the VMCSs to debug guest images contained >> in the host vmcore. To prevent the corruption, we should VMCLEAR the VMCSs before >> executing the VMXOFF instruction. >> >> The patch set provides a way to VMCLEAR vmcss related to guests on all cpus before >> executing the VMXOFF when doing kdump. This is used to ensure the VMCSs in the >> vmcore updated and non-corrupted. >> > Looks fine to me, but kexec part should get acks from exec maintainers. Thanks. I will ask the exec maintainer. > >> Changelog from v7 to v8: >> 1. KEXEC: regression for using name crash_notifier_list >> and remove comments related to KVM >> and just call function atomic_notifier_call_chain directly. >> >> Changelog from v6 to v7: >> 1. KVM-INTEL: in hardware_disable, we needn't disable the >> vmclear, so remove it. >> >> Changelog from v5 to v6: >> 1. KEXEC: the atomic notifier list renamed: >> crash_notifier_list --> vmclear_notifier_list >> 2. KVM-INTEL: provide empty functions if CONFIG_KEXEC is >> not defined and remove unnecessary #ifdef's. >> >> Changelog from v4 to v5: >> 1. use an atomic notifier instead of function call, so >> have all the vmclear codes in vmx.c. >> >> Changelog from v3 to v4: >> 1. add a new percpu variable vmclear_skipped to skip >> vmclear in kdump in some conditions. >> >> Changelog from v2 to v3: >> 1. remove unnecessary conditions in function >> cpu_emergency_clear_loaded_vmcss as Marcelo suggested. >> >> Changelog from v1 to v2: >> 1. remove the sysctl and clear VMCSs unconditionally. >> >> Zhang Yanfei (2): >> x86/kexec: add a new atomic notifier list for kdump >> KVM-INTEL: add a notifier and a bitmap to support VMCLEAR in kdump >> >> arch/x86/include/asm/kexec.h | 2 + >> arch/x86/kernel/crash.c | 9 +++++ >> arch/x86/kvm/vmx.c | 70 ++++++++++++++++++++++++++++++++++++++++++ >> 3 files changed, 81 insertions(+), 0 deletions(-) > > -- > Gleb. >