From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([208.118.235.92]:51858)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TcsLH-0003qU-FA
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 01:38:56 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TcsLG-0003uF-Ay
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 01:38:55 -0500
Received: from v220110690675601.yourvserver.net ([78.47.199.172]:55031)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <sw@weilnetz.de>) id 1TcsLG-0003tz-4s
	for qemu-devel@nongnu.org; Mon, 26 Nov 2012 01:38:54 -0500
Message-ID: <50B30E75.8030806@weilnetz.de>
Date: Mon, 26 Nov 2012 07:38:45 +0100
From: Stefan Weil <sw@weilnetz.de>
MIME-Version: 1.0
References: <1353794593-6147-1-git-send-email-sw@weilnetz.de>
	<20121126053153.GA3127@walimis-DELL>
In-Reply-To: <20121126053153.GA3127@walimis-DELL>
Content-Type: text/plain; charset=ISO-8859-1; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Qemu-devel] [PATCH for 1.3] pflash_cfi01: Suppress warning
 when Linux probes for AMD flash
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: walimis <walimisdev@gmail.com>
Cc: Blue Swirl <blauwirbel@gmail.com>, Peter Maydell <peter.maydell@linaro.org>, Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

Am 26.11.2012 06:31, schrieb walimis:
> On Sat, Nov 24, 2012 at 11:03:13PM +0100, Stefan Weil wrote:
>> There are several ARM and MIPS boards which are manufactured with
>> either Intel (pflash_cfi01.c) or AMD (pflash_cfi02.c) flash memory.
>>
>> The Linux kernel supports both and first probes for AMD flash which
>> resulted in one or two warnings from the Intel flash emulation:
>>
>> pflash_write: Unimplemented flash cmd sequence (offset 0000000000000000, wcycle 0x0 cmd 0x0 value 0xf000f0)
>> pflash_write: Unimplemented flash cmd sequence (offset 0000000000000000, wcycle 0x0 cmd 0x0 value 0xf0)
> Hi Stefan,
>
> I ever submited a similar patch to mailing list:
> http://patchwork.ozlabs.org/patch/147886/
>
> Do you have a look at that patch to see whether it's sane for the
> different parts between mine and yours?
>
> Thanks,
> Liming Wang

Hi,

your patch is technically identical, but I think that your commit message
ismisleading: it implies that 0xff and 0xf0 are both specified in the
CFI specification for Intel flash memory (CFI 01). As far as I could see,
0xf0 is only a specified flash command sequence for AMD flash memory 
(CFI 02).
That's why Linux uses it to detect that kind of flash memory.

If you resend your patch with a commit message and a comment in
the code which explains why 0xf0 needs handling in pflash_cfi01.c,
it can be committed IMHO.

Regards

Stefan