From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Zhang Subject: Re: [PATCH] drm: tegra: Use framebuffer pitch as line stride Date: Mon, 26 Nov 2012 15:01:34 +0800 Message-ID: <50B313CE.9090702@nvidia.com> References: <1353613037-15808-1-git-send-email-thierry.reding@avionic-design.de> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1353613037-15808-1-git-send-email-thierry.reding-RM9K5IK7kjKj5M59NBduVrNAH6kLmebB@public.gmane.org> Sender: linux-tegra-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Thierry Reding Cc: Dave Airlie , "dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org" , "linux-tegra-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , Marc Dietrich List-Id: linux-tegra@vger.kernel.org Tested-by: Mark Zhang On my Tegra 3 cardhu. Mark On 11/23/2012 03:37 AM, Thierry Reding wrote: > Instead of using the stride derived from the display mode, use the pitch > associated with the currently active framebuffer. This fixes a bug where > the LCD display content would be skewed when enabling HDMI with a video > mode different from that of the LCD. > > Signed-off-by: Thierry Reding > --- > drivers/gpu/drm/tegra/dc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tegra/dc.c b/drivers/gpu/drm/tegra/dc.c > index 94686e5..41cde76 100644 > --- a/drivers/gpu/drm/tegra/dc.c > +++ b/drivers/gpu/drm/tegra/dc.c > @@ -218,7 +218,7 @@ static int tegra_crtc_mode_set(struct drm_crtc *crtc, > } > > bpp = crtc->fb->bits_per_pixel / 8; > - win.stride = win.outw * bpp; > + win.stride = crtc->fb->pitches[0]; > > /* program window registers */ > value = tegra_dc_readl(dc, DC_CMD_DISPLAY_WINDOW_HEADER); >