From: Bart Van Assche <bvanassche@acm.org>
To: David Dillow <dillowda@ornl.gov>
Cc: linux-rdma@vger.kernel.org, linux-scsi@vger.kernel.org,
roland@purestorage.com
Subject: Re: [PATCH 02/11] IB/srp: simplify state tracking
Date: Mon, 26 Nov 2012 10:46:57 +0100 [thread overview]
Message-ID: <50B33A91.3060103@acm.org> (raw)
In-Reply-To: <6f9ad200f981a2fe49319e7437c842f03063a4f1.1353903448.git.dillowda@ornl.gov>
On 11/26/12 05:44, David Dillow wrote:
> The state of the target has several conditions that overlap, making it
> easier to model as a bit-field of exceptional conditions rather than an
> enum of all possible states.
>
> Bart Van Assche did the hard work of identifying the states that can be
> removed, and did a first patch that consolidated the state space.
[ ... ]
Hi Dave,
Could you please explain why you would prefer to use test_bit () /
test_and_set_bit() and clear_bit() for managing the SRP target state ?
As far as I can see the target state is not changed in any code path
where it matters how fast the state is changed. Maybe I'm missing
something ?
Thanks,
Bart.
next prev parent reply other threads:[~2012-11-26 9:46 UTC|newest]
Thread overview: 45+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-26 4:44 [PATCH 00/11] First pass at merging Bart's HA work David Dillow
2012-11-26 4:44 ` [PATCH 01/11] IB/srp: enlarge block layer timeout David Dillow
2012-11-26 4:44 ` [PATCH 02/11] IB/srp: simplify state tracking David Dillow
2012-11-26 9:46 ` Bart Van Assche [this message]
[not found] ` <50B33A91.3060103-HInyCGIudOg@public.gmane.org>
2012-11-27 3:56 ` David Dillow
[not found] ` <cover.1353903448.git.dillowda-1Heg1YXhbW8@public.gmane.org>
2012-11-26 4:44 ` [PATCH 03/11] IB/srp: don't send anything on a bad QP David Dillow
2012-11-26 9:17 ` Bart Van Assche
[not found] ` <50B333AF.6040509-HInyCGIudOg@public.gmane.org>
2012-11-27 3:31 ` David Dillow
2012-11-26 4:44 ` [PATCH 04/11] IB/srp: keep processing commands during host removal David Dillow
[not found] ` <8715294a23dded5879b3a327c470d9b6a39ddbc4.1353903448.git.dillowda-1Heg1YXhbW8@public.gmane.org>
2012-11-26 9:43 ` Bart Van Assche
2012-11-27 3:16 ` David Dillow
2012-11-26 4:44 ` [PATCH 08/11] srp_transport: Fix attribute registration David Dillow
2012-11-26 4:44 ` [PATCH 09/11] srp_transport: Simplify attribute initialization code David Dillow
2012-11-26 5:02 ` David Dillow
2012-11-26 4:44 ` [PATCH 11/11] IB/srp: Allow SRP disconnect through sysfs David Dillow
2012-11-26 4:44 ` [PATCH 05/11] IB/srp: destroy and recreate QP and CQs on each connection David Dillow
[not found] ` <8fa9a268ec4dc587970161efe94968f3263aad3b.1353903448.git.dillowda-1Heg1YXhbW8@public.gmane.org>
2012-11-26 18:57 ` Bart Van Assche
2012-11-26 4:44 ` [PATCH 06/11] IB/srp: send disconnect request without waiting for CM timewait exit David Dillow
2012-11-26 4:44 ` [PATCH 07/11] IB/srp: Document sysfs attributes David Dillow
2012-11-26 4:44 ` [PATCH 10/11] srp_transport: " David Dillow
2012-11-26 7:57 ` [PATCH 00/11] First pass at merging Bart's HA work Or Gerlitz
2012-11-27 4:53 ` David Dillow
2012-11-26 18:50 ` Roland Dreier
2012-11-26 19:15 ` James Bottomley
2012-11-26 19:22 ` Roland Dreier
2012-11-27 4:04 ` David Dillow
[not found] ` <1353989041.28917.24.camel-1q1vX8mYZiGLUyTwlgNVppKKF0rrzTr+@public.gmane.org>
2012-11-27 6:42 ` Or Gerlitz
2012-11-29 20:21 ` Roland Dreier
[not found] ` <CAL1RGDXpdWL_r7sWp=vvvXH4jxFgjDL+XcEGgKo-44=wrOBmtA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-30 2:21 ` David Dillow
2012-12-05 18:23 ` Or Gerlitz
[not found] ` <CAJZOPZJBTRXftrW5NWEEHnf2QWsni0HMTAV_PKSgDtA7GO=wRw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-12-05 18:50 ` Bart Van Assche
[not found] ` <50BF9760.2080801-HInyCGIudOg@public.gmane.org>
2012-12-05 19:50 ` Bart Van Assche
2012-12-05 21:32 ` Or Gerlitz
2012-12-06 14:10 ` Bart Van Assche
[not found] ` <50C0A76C.20500-HInyCGIudOg@public.gmane.org>
2012-12-06 14:27 ` Or Gerlitz
[not found] ` <50C0AB42.8040402-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-12-06 15:04 ` Bart Van Assche
[not found] ` <50C0B407.4010706-HInyCGIudOg@public.gmane.org>
2012-12-06 15:46 ` Or Gerlitz
2012-12-06 15:55 ` Alex Turin
[not found] ` <50C0BFE0.909-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-12-07 21:47 ` Vu Pham
[not found] ` <50C263E2.1070805-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2012-12-08 11:15 ` Bart Van Assche
2012-12-07 8:19 ` Or Gerlitz
2012-11-27 16:34 ` Bart Van Assche
[not found] ` <50B4EBA3.7070400-HInyCGIudOg@public.gmane.org>
2012-11-27 18:10 ` Joseph Glanville
2012-11-27 22:13 ` Or Gerlitz
[not found] ` <CAJZOPZJ6tNimvQGKa6E0ttowM8WWxCMR7s9BMWebVOEYtQ+TCQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2012-11-28 13:33 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B33A91.3060103@acm.org \
--to=bvanassche@acm.org \
--cc=dillowda@ornl.gov \
--cc=linux-rdma@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=roland@purestorage.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.