All of lore.kernel.org
 help / color / mirror / Atom feed
From: Clemens Ladisch <clemens@ladisch.de>
To: Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
	David Henningsson <david.henningsson@canonical.com>,
	zonque@gmail.com
Subject: Re: [PATCH] ALSA: usb - Don't create "Speaker" mixer controls on headphones and headsets
Date: Mon, 26 Nov 2012 11:06:41 +0100	[thread overview]
Message-ID: <50B33F31.8000603@ladisch.de> (raw)
In-Reply-To: <s5hip8sitzm.wl%tiwai@suse.de>

Takashi Iwai wrote:
> David Henningsson wrote:
>> A lot of headsets/headphones have a "Speaker" mixer control. This confuses
>> PulseAudio to think it is a speaker instead of a headphone/headset.
>> Therfore, we rename it to "Headphone".
>>
>> We determine if something is a headphone similar to how udev determines
>> form factor (see 78-sound-card.rules).
>>
>> BugLink: https://bugs.launchpad.net/bugs/1082357
>> Signed-off-by: David Henningsson <david.henningsson@canonical.com>
>> ---
>>  sound/usb/mixer.c |   30 ++++++++++++++++++++++++++++++
>>  1 file changed, 30 insertions(+)
>>
>> I tried to find a better way of doing this using the existing quirk or
>> map infrastructure but it didn't seem to fit, so added a new
>> explicit check.
>
> Hrm, indeed it's pretty hackish although it'd work heuristically.

This is for devices that have explicitly marked their output
terminal as speakers, so I don't see any method to make this less
hackish.


Regards,
Clemens

  reply	other threads:[~2012-11-26 10:06 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-11-23 12:48 [PATCH] ALSA: usb - Don't create "Speaker" mixer controls on headphones and headsets David Henningsson
2012-11-26  9:38 ` Takashi Iwai
2012-11-26 10:06   ` Clemens Ladisch [this message]
2012-11-29 13:00     ` Takashi Iwai
2012-11-26 15:21 ` Raymond Yau
2012-11-26 15:26   ` David Henningsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B33F31.8000603@ladisch.de \
    --to=clemens@ladisch.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=david.henningsson@canonical.com \
    --cc=tiwai@suse.de \
    --cc=zonque@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.