Re: [Qemu-devel] [PATCH 01/34] qdev: Eliminate qdev_free() in favor of QOM

[Paolo Bonzini <pbonzini@redhat.com>]

Il 26/11/2012 12:52, Andreas Färber ha scritto:
> Am 26.11.2012 08:20, schrieb Paolo Bonzini:
>> Il 26/11/2012 01:12, Andreas Färber ha scritto:
>>> qdev_free() was trivially wrapping object_delete(). Inline it and drop
>>> the wrapper as a further step to QOM'ify qdev.
>>
>> The reference counts of devices and buses are completely disconnected
>> from reality, and that's why object_delete() works.
>>
>> I'd prefer this patch not to be applied until this is straightened out...
> 
> Your series is marked for-1.3 whereas this is for 1.4, so no obvious
> problem there - wanted to mention the overlap in the cover letter but
> apparently forgot.

I have a more complete series for 1.4 (needs a bit more testing, but I
guess I can send out an RFC).  The one I posted for 1.3 is a subset.

> My quest was to kill obsolete things with old "qdev" in the name. :)
> I don't really mind if this becomes object_delete() or object_unref() or
> anything else as long as it's not such a trivial qdev_* wrapper calling
> one QOM object_* function.

Ok, that's fine.

Paolo