All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org,
	Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>,
	Dietmar Maurer <dietmar@proxmox.com>
Subject: Re: [Qemu-devel] [PATCH] stream: fix ratelimit_set_speed
Date: Mon, 26 Nov 2012 17:23:09 +0100	[thread overview]
Message-ID: <50B3976D.9030804@redhat.com> (raw)
In-Reply-To: <50ACD600.9020102@redhat.com>

Am 21.11.2012 14:24, schrieb Paolo Bonzini:
> Il 24/10/2012 12:10, Dietmar Maurer ha scritto:
>> The formula to compute slice_quota was wrong.
>>
>> Signed-off-by: Dietmar Maurer <dietmar@proxmox.com>
>> ---
>>  include/qemu/ratelimit.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/include/qemu/ratelimit.h b/include/qemu/ratelimit.h
>> index c6ac281..d1610f1 100644
>> --- a/include/qemu/ratelimit.h
>> +++ b/include/qemu/ratelimit.h
>> @@ -42,7 +42,7 @@ static inline void ratelimit_set_speed(RateLimit *limit, uint64_t speed,
>>                                         uint64_t slice_ns)
>>  {
>>      limit->slice_ns = slice_ns;
>> -    limit->slice_quota = ((double)speed * 1000000000ULL) / slice_ns;
>> +    limit->slice_quota = ((double)speed * slice_ns)/1000000000ULL;
>>  }
>>  
>>  #endif
>>
> 
> Ping... Stefan, can you commit this fix to block branch too?

Thanks, applied to the block branch for 1.3.

Kevin

      reply	other threads:[~2012-11-26 16:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-24 10:10 [Qemu-devel] [PATCH] stream: fix ratelimit_set_speed Dietmar Maurer
2012-10-24 23:29 ` Eric Blake
2012-11-21 13:24 ` Paolo Bonzini
2012-11-26 16:23   ` Kevin Wolf [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50B3976D.9030804@redhat.com \
    --to=kwolf@redhat.com \
    --cc=dietmar@proxmox.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.