From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:58595) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td8kt-0000qK-Jl for qemu-devel@nongnu.org; Mon, 26 Nov 2012 19:10:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Td8kr-00084q-SG for qemu-devel@nongnu.org; Mon, 26 Nov 2012 19:10:27 -0500 Received: from cantor2.suse.de ([195.135.220.15]:49661 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Td8kr-00084E-LF for qemu-devel@nongnu.org; Mon, 26 Nov 2012 19:10:25 -0500 Message-ID: <50B404E8.6070102@suse.de> Date: Tue, 27 Nov 2012 01:10:16 +0100 From: =?ISO-8859-15?Q?Andreas_F=E4rber?= MIME-Version: 1.0 References: <0bc7997d87e325be985811d2627c339f7fc2b961.1348052498.git.julien.grall@citrix.com> In-Reply-To: <0bc7997d87e325be985811d2627c339f7fc2b961.1348052498.git.julien.grall@citrix.com> Content-Type: text/plain; charset=ISO-8859-15 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V10 2/8] hw/apm.c: replace register_ioport* List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Julien Grall , Jason Baron Cc: qemu-devel@nongnu.org, jan.kiszka@siemens.com, kraxel@redhat.com, avi@redhat.com, Stefano.Stabellini@eu.citrix.com Am 19.09.2012 13:50, schrieb Julien Grall: > This patch replaces all register_ioport* by a MemorySection. > It permits to use the new Memory stuff like listener. >=20 > Moreover, the PCI is added as an argument for apm_init, so we > can register IO inside the pci IO address space. >=20 > Signed-off-by: Julien Grall Following today's q35 merge I needed the following diff to fix the build: diff --git a/hw/lpc_ich9.c b/hw/lpc_ich9.c index 2fc83a4..7de5427 100644 --- a/hw/lpc_ich9.c +++ b/hw/lpc_ich9.c @@ -472,7 +472,7 @@ static int ich9_lpc_initfn(PCIDevice *d) lpc->isa_bus =3D isa_bus; ich9_cc_init(lpc); - apm_init(&lpc->apm, ich9_apm_ctrl_changed, lpc); + apm_init(d, &lpc->apm, ich9_apm_ctrl_changed, lpc); return 0; } Julien/Jason, can you please verify that this is the correct device to pa= ss? Thanks, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=FCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=F6rffer; HRB 16746 AG N=FCrnbe= rg