From mboxrd@z Thu Jan 1 00:00:00 1970 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= Subject: Re: [PATCH V3] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs Date: Tue, 27 Nov 2012 02:51:07 +0100 Message-ID: <50B41C8B.5060302@suse.de> References: <1353980434.8358.2.camel@WillAuldHomeLinux> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: "jinsong.liu@intel.com" , "kvm@vger.kernel.org" , Gleb , "mtosatti@redhat.com" , Will Auld , qemu-devel , "donald.d.dugger@intel.com" , "avi@redhat.com" To: will.auld@intel.com Return-path: In-Reply-To: <1353980434.8358.2.camel@WillAuldHomeLinux> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org Sender: qemu-devel-bounces+gceq-qemu-devel=gmane.org@nongnu.org List-Id: kvm.vger.kernel.org Am 27.11.2012 02:40, schrieb Will Auld: > CPUID.7.0.EBX[1]=3D1 indicates IA32_TSC_ADJUST MSR 0x3b is supported >=20 > Basic design is to emulate the MSR by allowing reads and writes to the > hypervisor vcpu specific locations to store the value of the emulated M= SRs. > In this way the IA32_TSC_ADJUST value will be included in all reads to > the TSC MSR whether through rdmsr or rdtsc. >=20 > As this is a new MSR that the guest may access and modify its value nee= ds > to be migrated along with the other MRSs. The changes here are specific= ally > for recognizing when IA32_TSC_ADJUST is enabled in CPUID and code added > for migrating its value. >=20 > Signed-off-by: Will Auld Something went wrong here, none of the V2 review comments are addressed. Maybe you sent the wrong patch file? Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:56737) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdAKR-0003fh-2N for qemu-devel@nongnu.org; Mon, 26 Nov 2012 20:51:15 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdAKQ-00010i-7U for qemu-devel@nongnu.org; Mon, 26 Nov 2012 20:51:15 -0500 Received: from cantor2.suse.de ([195.135.220.15]:52669 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdAKQ-00010e-0w for qemu-devel@nongnu.org; Mon, 26 Nov 2012 20:51:14 -0500 Message-ID: <50B41C8B.5060302@suse.de> Date: Tue, 27 Nov 2012 02:51:07 +0100 From: =?UTF-8?B?QW5kcmVhcyBGw6RyYmVy?= MIME-Version: 1.0 References: <1353980434.8358.2.camel@WillAuldHomeLinux> In-Reply-To: <1353980434.8358.2.camel@WillAuldHomeLinux> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH V3] target-i386: Enabling IA32_TSC_ADJUST for QEMU KVM guest VMs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: will.auld@intel.com Cc: "jinsong.liu@intel.com" , "kvm@vger.kernel.org" , Gleb , "mtosatti@redhat.com" , Will Auld , qemu-devel , "donald.d.dugger@intel.com" , "avi@redhat.com" Am 27.11.2012 02:40, schrieb Will Auld: > CPUID.7.0.EBX[1]=3D1 indicates IA32_TSC_ADJUST MSR 0x3b is supported >=20 > Basic design is to emulate the MSR by allowing reads and writes to the > hypervisor vcpu specific locations to store the value of the emulated M= SRs. > In this way the IA32_TSC_ADJUST value will be included in all reads to > the TSC MSR whether through rdmsr or rdtsc. >=20 > As this is a new MSR that the guest may access and modify its value nee= ds > to be migrated along with the other MRSs. The changes here are specific= ally > for recognizing when IA32_TSC_ADJUST is enabled in CPUID and code added > for migrating its value. >=20 > Signed-off-by: Will Auld Something went wrong here, none of the V2 review comments are addressed. Maybe you sent the wrong patch file? Cheers, Andreas --=20 SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 N=C3=BCrnberg, Germany GF: Jeff Hawn, Jennifer Guild, Felix Imend=C3=B6rffer; HRB 16746 AG N=C3=BC= rnberg