From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:36269) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdHCF-0001rx-5D for qemu-devel@nongnu.org; Tue, 27 Nov 2012 04:11:19 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdHC9-0000ET-5K for qemu-devel@nongnu.org; Tue, 27 Nov 2012 04:11:14 -0500 Received: from mx1.redhat.com ([209.132.183.28]:22204) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdHC8-0000EJ-To for qemu-devel@nongnu.org; Tue, 27 Nov 2012 04:11:09 -0500 Message-ID: <50B483A5.3050005@redhat.com> Date: Tue, 27 Nov 2012 10:11:01 +0100 From: Paolo Bonzini MIME-Version: 1.0 References: <1353749244-25676-1-git-send-email-xiawenc@linux.vnet.ibm.com> <1353749244-25676-7-git-send-email-xiawenc@linux.vnet.ibm.com> <50B32979.6010905@redhat.com> <50B431FD.8050809@linux.vnet.ibm.com> In-Reply-To: <50B431FD.8050809@linux.vnet.ibm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH V11 6/7] libqblock API implement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Wenchao Xia Cc: kwolf@redhat.com, stefanha@gmail.com, aliguori@us.ibm.com, qemu-devel@nongnu.org, blauwirbel@gmail.com Il 27/11/2012 04:22, Wenchao Xia ha scritto: >>> >> >> There is no need (yet) to do these three steps. Once we add an >> asynchronous I/O API, we can add an API to get an AioContext from a >> QBlockContext. >> >> This however requires support for multiple AioContexts, I think. So >> that's left for later. >> > It seems aio_context_new() and bdrv_init() must be called to make sure > block API works Yes, those two are needed. > , should this function be deleted now and move this > initial calls into another new function libqblock_init()? Your choice. :) Paolo