From: Joe Kulikauskas <joe.kulikauskas@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] arm: empty isb() in set_cr
Date: Tue, 27 Nov 2012 08:01:16 -0700 [thread overview]
Message-ID: <50B4D5BC.5030907@gmail.com> (raw)
#define isb() __asm__ __volatile__ ("" : : : "memory")
is in arch/arm/include/asm/system.h. In my build, that is going into
set_cr(), producing no instruction.
Is that correct? It has been in code since
http://lists.denx.de/pipermail/u-boot/2009-March/049870.html.
Looks like it's used only in set_cr. Other points in the code have
nonempty code for ISB, for example
#define CP15ISB asm volatile ("mcr p15, 0, %0, c7, c5, 4" : : "r"
(0))
which is in armv7.h
I don't have a standard reference platform to experiment with. The
platform that I have uses a Cortex-A9 core, u-boot.2012.07 is ported and
running. There are some intermittent issues there relating to enabling
MMU/cache, lack of instruction barriers would be a plausible explanation.
Adding ISB SY in set_cr doesn't fix my issues, but it looks like a step
in right direction. If someone could explain, or point me to email, I
would appreciate it. Thanks in advance.
reply other threads:[~2012-11-27 15:01 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B4D5BC.5030907@gmail.com \
--to=joe.kulikauskas@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.