From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:42460) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdNxC-0004qG-Fw for qemu-devel@nongnu.org; Tue, 27 Nov 2012 11:24:14 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdNxB-0005Gw-AQ for qemu-devel@nongnu.org; Tue, 27 Nov 2012 11:24:10 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56159 helo=mx2.suse.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdNxB-0005Gk-3Z for qemu-devel@nongnu.org; Tue, 27 Nov 2012 11:24:09 -0500 Message-ID: <50B4E924.109@suse.de> Date: Tue, 27 Nov 2012 17:24:04 +0100 From: Alexander Graf MIME-Version: 1.0 References: <1354033263-32748-1-git-send-email-pbonzini@redhat.com> In-Reply-To: <1354033263-32748-1-git-send-email-pbonzini@redhat.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH v2 1.3] build: compile translate.o with -fno-gcse option List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: peter.maydell@linaro.org, qemu-devel@nongnu.org, kraxel@redhat.com On 11/27/2012 05:21 PM, Paolo Bonzini wrote: > Some versions of GCC require insane (>2GB) amounts of memory to compile > translate.o. As a countermeasure, disable the culprit optimization pass. > This should fix the buildbot failure for default_x86_64_fedora16. > Anyway is a good thing to do because people will try to compile 1.3 with > less than 2GB of memory and complain. > > Signed-off-by: Paolo Bonzini > --- > Makefile.target | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/Makefile.target b/Makefile.target > index 8b658c0..d38bb58 100644 > --- a/Makefile.target > +++ b/Makefile.target > @@ -143,6 +143,12 @@ GENERATED_HEADERS += hmp-commands.h qmp-commands-old.h > > endif # CONFIG_SOFTMMU > > +# Workaround for http://gcc.gnu.org/PR55489. Happens with -fPIE/-fPIC > +# and large functions that use global variables. The bug is in all > +# releases of GCC, but it became particularly acute in 4.7.x. We > +# should be able to delete this at the end of 2013. Can we add a version check for gcc here? Alex > +%/translate.o: QEMU_CFLAGS += -fno-gcse > + > nested-vars += obj-y > > # This resolves all nested paths, so it must come last