From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Sandeen Subject: Re: How to run xfstests against multipath disks on SuSE? Date: Tue, 27 Nov 2012 14:37:09 -0600 Message-ID: <50B52475.1020603@redhat.com> References: <20121126145559.GK31891@thunk.org> <20121127031438.GK6434@dastard> <50B4F38E.8060806@redhat.com> <20121127203537.GM6434@dastard> Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: Ryan Wang , "Theodore Ts'o" , =?UTF-8?B?THVrw6HFoSBDemVybmVy?= , linux-ext4@vger.kernel.org, xfs@oss.sgi.com To: Dave Chinner Return-path: Received: from mx1.redhat.com ([209.132.183.28]:47620 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756559Ab2K0UhT (ORCPT ); Tue, 27 Nov 2012 15:37:19 -0500 In-Reply-To: <20121127203537.GM6434@dastard> Sender: linux-ext4-owner@vger.kernel.org List-ID: On 11/27/12 2:35 PM, Dave Chinner wrote: > On Tue, Nov 27, 2012 at 11:08:30AM -0600, Eric Sandeen wrote: >> On 11/26/12 9:14 PM, Dave Chinner wrote: >>> On Tue, Nov 27, 2012 at 09:20:47AM +0800, Ryan Wang wrote: >>>> 2012/11/26 Theodore Ts'o : >>>>> On Mon, Nov 26, 2012 at 02:43:40PM +0100, Luk=C3=A1=C5=A1 Czerner= wrote: >>>>>>> The I checked the script common.rc, and found that it uses >>>>>>> df to determine the filesystem type and it uses the realpath >>>>>>> "/dev/dm-0" instead of "/dev/mapper/mpatha", while df always >>>>>>> shows "devtmpfs" instead of "ext4" for /dev/dm-0. >>>>>>> >>>>>>> I run "mount" and found that devtmpfs is mount on /dev/ on open= suse >>>>>>> ***by default***. Even though I run "mount -t btrfs /dev/dm-0 = /somedir", >>>>>>> df still showed devtmpfs. >>>>>>> >>>>>>> Any ideas to kick off the xfstests? >>>>> >>>>> At least with the df which ships with Debian Testing, df will dis= play >>>>> the file system in use if it matches the device name which is >>>>> /etc/mtab. It looks the issue is that mount is canonicalizing th= e >>>>> device name to be the human friendly version: >>>>> >>>>> # ls -l /dev/mapper/closure-bigscratch >>>>> 0 lrwxrwxrwx 1 root root 7 Nov 16 15:15 /dev/mapper/closure-bigsc= ratch -> ../dm-7 >>>>> {/home/tytso/bin}, level 2 >>>>> # mount /dev/dm-7 /u2 >>>>> # df /u2 >>>>> Filesystem 1K-blocks Used Available Use% Mo= unted on >>>>> /dev/mapper/closure-bigscratch 52403200 224772 52178428 1% /u= 2 >>>>> # grep /u2 /etc/mtab >>>>> /dev/mapper/closure-bigscratch /u2 xfs rw,relatime,attr2,inode64,= noquota 0 0 >>>>> >>>>> So the simplest solution is to just use /dev/mapper/mpatha instea= d of >>>>> insisting on using /dev/dm-0. That's what I do.... >>>> >>>> In xfstests/common.rc, it will use realpath to obtain /dev/dm-0, e= ven if you >>>> specified /dev/mapper/mpatha. >>>> My problem is in SuSE, the devtmpfs is mounted on /dev by default,= seems >>>> used by udev. And df reports devtmpfs on /dev/dm-0, instead of ext= 4. >>> >>> What version of xfstests are you using? Do you have a >>> "README.device-mapper" file in the base directory? If not, upgrade >>> to the latest version and retry. >>> >>> $ gl -n 1 -p 0a81886 >>> commit 0a818862bb74932e15971ec8bedb55765ec3a3f6 >>> Author: Christoph Hellwig >>> Date: Wed May 4 16:28:32 2011 +0200 >>> >>> xfstests: support post-udev device mapper nodes >>> >>> Because of udevs complaining device mapper now creates /dev/dm-= N as the real >>> device nodes, and just symlinks the /dev/mapper/ names to it. = This would be >>> easy if everything used the /dev/mapper clear names, but most s= ystem utilities >>> translate them back to the /dev/mapper/ names and thus confuse = various test >>> cases. Add support to _is_block_dev to read symlinks, and add = documentation >>> on how to run xfstests on device mapper volumes. >>> >>> Signed-off-by: Christoph Hellwig >>> Reviewed-by: Alex Elder >>> >>> Cheers, >>> >>> Dave. >>> >> >> Recent "realpath" changes also went in: >> >> b03c662399956609934ff063e9064e15dc7459ac xfstests: fix to build src/= realpath and the correct the existence of target devices >> d5ea873fcbf00b841f0511a26fb341364a5c6425 xfstests: resolve symlinked= devices to real paths >> >> so either of those could have broken and/or fixed it for you :) >=20 > Yup, those are almost certainly the patches that broke device mapper > support. There' aren't changes to common.rc, so I didn't notice them. > They basically override the fix that Christoph made to support > /dev/mapper links properly. >=20 > I'd suggest a revert is in order, the two patches above were part > of Rich's hovering of old, unreviewed patches. This problem was > already fixed in a different way by Christoph, so adding these > patches was wrong. =46ine with me ... Ryan, can you test w/o those, and if it works - Rich, can you revert those please? -Eric > Cheers, >=20 > Dave. >=20 -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" i= n the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id qARKZ2F7085505 for ; Tue, 27 Nov 2012 14:35:02 -0600 Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by cuda.sgi.com with ESMTP id oLxur0fUwT189rsV for ; Tue, 27 Nov 2012 12:37:18 -0800 (PST) Message-ID: <50B52475.1020603@redhat.com> Date: Tue, 27 Nov 2012 14:37:09 -0600 From: Eric Sandeen MIME-Version: 1.0 Subject: Re: How to run xfstests against multipath disks on SuSE? References: <20121126145559.GK31891@thunk.org> <20121127031438.GK6434@dastard> <50B4F38E.8060806@redhat.com> <20121127203537.GM6434@dastard> In-Reply-To: <20121127203537.GM6434@dastard> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: =?UTF-8?B?THVrw6HFoSBDemVybmVy?= , Ryan Wang , linux-ext4@vger.kernel.org, Theodore Ts'o , xfs@oss.sgi.com T24gMTEvMjcvMTIgMjozNSBQTSwgRGF2ZSBDaGlubmVyIHdyb3RlOgo+IE9uIFR1ZSwgTm92IDI3 LCAyMDEyIGF0IDExOjA4OjMwQU0gLTA2MDAsIEVyaWMgU2FuZGVlbiB3cm90ZToKPj4gT24gMTEv MjYvMTIgOToxNCBQTSwgRGF2ZSBDaGlubmVyIHdyb3RlOgo+Pj4gT24gVHVlLCBOb3YgMjcsIDIw MTIgYXQgMDk6MjA6NDdBTSArMDgwMCwgUnlhbiBXYW5nIHdyb3RlOgo+Pj4+IDIwMTIvMTEvMjYg VGhlb2RvcmUgVHMnbyA8dHl0c29AbWl0LmVkdT46Cj4+Pj4+IE9uIE1vbiwgTm92IDI2LCAyMDEy IGF0IDAyOjQzOjQwUE0gKzAxMDAsIEx1a8OhxaEgQ3plcm5lciB3cm90ZToKPj4+Pj4+PiBUaGUg SSBjaGVja2VkIHRoZSBzY3JpcHQgY29tbW9uLnJjLCBhbmQgZm91bmQgdGhhdCBpdCB1c2VzCj4+ Pj4+Pj4gZGYgdG8gZGV0ZXJtaW5lIHRoZSBmaWxlc3lzdGVtIHR5cGUgYW5kIGl0IHVzZXMgdGhl IHJlYWxwYXRoCj4+Pj4+Pj4gIi9kZXYvZG0tMCIgaW5zdGVhZCBvZiAiL2Rldi9tYXBwZXIvbXBh dGhhIiwgd2hpbGUgZGYgYWx3YXlzCj4+Pj4+Pj4gc2hvd3MgImRldnRtcGZzIiBpbnN0ZWFkIG9m ICJleHQ0IiBmb3IgL2Rldi9kbS0wLgo+Pj4+Pj4+Cj4+Pj4+Pj4gSSBydW4gIm1vdW50IiBhbmQg Zm91bmQgdGhhdCBkZXZ0bXBmcyBpcyBtb3VudCBvbiAvZGV2LyBvbiBvcGVuc3VzZQo+Pj4+Pj4+ ICoqKmJ5IGRlZmF1bHQqKiouIEV2ZW4gdGhvdWdoICBJIHJ1biAibW91bnQgLXQgYnRyZnMgL2Rl di9kbS0wIC9zb21lZGlyIiwKPj4+Pj4+PiBkZiBzdGlsbCBzaG93ZWQgZGV2dG1wZnMuCj4+Pj4+ Pj4KPj4+Pj4+PiBBbnkgaWRlYXMgdG8ga2ljayBvZmYgdGhlIHhmc3Rlc3RzPwo+Pj4+Pgo+Pj4+ PiBBdCBsZWFzdCB3aXRoIHRoZSBkZiB3aGljaCBzaGlwcyB3aXRoIERlYmlhbiBUZXN0aW5nLCBk ZiB3aWxsIGRpc3BsYXkKPj4+Pj4gdGhlIGZpbGUgc3lzdGVtIGluIHVzZSBpZiBpdCBtYXRjaGVz IHRoZSBkZXZpY2UgbmFtZSB3aGljaCBpcwo+Pj4+PiAvZXRjL210YWIuICBJdCBsb29rcyB0aGUg aXNzdWUgaXMgdGhhdCBtb3VudCBpcyBjYW5vbmljYWxpemluZyB0aGUKPj4+Pj4gZGV2aWNlIG5h bWUgdG8gYmUgdGhlIGh1bWFuIGZyaWVuZGx5IHZlcnNpb246Cj4+Pj4+Cj4+Pj4+ICMgbHMgLWwg L2Rldi9tYXBwZXIvY2xvc3VyZS1iaWdzY3JhdGNoCj4+Pj4+IDAgbHJ3eHJ3eHJ3eCAxIHJvb3Qg cm9vdCA3IE5vdiAxNiAxNToxNSAvZGV2L21hcHBlci9jbG9zdXJlLWJpZ3NjcmF0Y2ggLT4gLi4v ZG0tNwo+Pj4+PiA8dHl0c28ucm9vdEBjbG9zdXJlPiB7L2hvbWUvdHl0c28vYmlufSwgbGV2ZWwg Mgo+Pj4+PiAjIG1vdW50IC9kZXYvZG0tNyAvdTIKPj4+Pj4gIyBkZiAvdTIKPj4+Pj4gRmlsZXN5 c3RlbSAgICAgICAgICAgICAgICAgICAgIDFLLWJsb2NrcyAgIFVzZWQgQXZhaWxhYmxlIFVzZSUg TW91bnRlZCBvbgo+Pj4+PiAvZGV2L21hcHBlci9jbG9zdXJlLWJpZ3NjcmF0Y2ggIDUyNDAzMjAw IDIyNDc3MiAgNTIxNzg0MjggICAxJSAvdTIKPj4+Pj4gIyBncmVwIC91MiAvZXRjL210YWIKPj4+ Pj4gL2Rldi9tYXBwZXIvY2xvc3VyZS1iaWdzY3JhdGNoIC91MiB4ZnMgcncscmVsYXRpbWUsYXR0 cjIsaW5vZGU2NCxub3F1b3RhIDAgMAo+Pj4+Pgo+Pj4+PiBTbyB0aGUgc2ltcGxlc3Qgc29sdXRp b24gaXMgdG8ganVzdCB1c2UgL2Rldi9tYXBwZXIvbXBhdGhhIGluc3RlYWQgb2YKPj4+Pj4gaW5z aXN0aW5nIG9uIHVzaW5nIC9kZXYvZG0tMC4gIFRoYXQncyB3aGF0IEkgZG8uLi4uCj4+Pj4KPj4+ PiBJbiB4ZnN0ZXN0cy9jb21tb24ucmMsIGl0IHdpbGwgdXNlIHJlYWxwYXRoIHRvIG9idGFpbiAv ZGV2L2RtLTAsIGV2ZW4gaWYgeW91Cj4+Pj4gc3BlY2lmaWVkIC9kZXYvbWFwcGVyL21wYXRoYS4K Pj4+PiBNeSBwcm9ibGVtIGlzIGluIFN1U0UsIHRoZSBkZXZ0bXBmcyBpcyBtb3VudGVkIG9uIC9k ZXYgYnkgZGVmYXVsdCwgc2VlbXMKPj4+PiB1c2VkIGJ5IHVkZXYuIEFuZCBkZiByZXBvcnRzIGRl dnRtcGZzIG9uIC9kZXYvZG0tMCwgaW5zdGVhZCBvZiBleHQ0Lgo+Pj4KPj4+IFdoYXQgdmVyc2lv biBvZiB4ZnN0ZXN0cyBhcmUgeW91IHVzaW5nPyBEbyB5b3UgaGF2ZSBhCj4+PiAiUkVBRE1FLmRl dmljZS1tYXBwZXIiIGZpbGUgaW4gdGhlIGJhc2UgZGlyZWN0b3J5PyBJZiBub3QsIHVwZ3JhZGUK Pj4+IHRvIHRoZSBsYXRlc3QgdmVyc2lvbiBhbmQgcmV0cnkuCj4+Pgo+Pj4gJCBnbCAtbiAxIC1w IDBhODE4ODYKPj4+IGNvbW1pdCAwYTgxODg2MmJiNzQ5MzJlMTU5NzFlYzhiZWRiNTU3NjVlYzNh M2Y2Cj4+PiBBdXRob3I6IENocmlzdG9waCBIZWxsd2lnIDxoY2hAbHN0LmRlPgo+Pj4gRGF0ZTog ICBXZWQgTWF5IDQgMTY6Mjg6MzIgMjAxMSArMDIwMAo+Pj4KPj4+ICAgICB4ZnN0ZXN0czogc3Vw cG9ydCBwb3N0LXVkZXYgZGV2aWNlIG1hcHBlciBub2Rlcwo+Pj4KPj4+ICAgICBCZWNhdXNlIG9m IHVkZXZzIGNvbXBsYWluaW5nIGRldmljZSBtYXBwZXIgbm93IGNyZWF0ZXMgL2Rldi9kbS1OIGFz IHRoZSByZWFsCj4+PiAgICAgZGV2aWNlIG5vZGVzLCBhbmQganVzdCBzeW1saW5rcyB0aGUgL2Rl di9tYXBwZXIvIG5hbWVzIHRvIGl0LiAgVGhpcyB3b3VsZCBiZQo+Pj4gICAgIGVhc3kgaWYgZXZl cnl0aGluZyB1c2VkIHRoZSAvZGV2L21hcHBlciBjbGVhciBuYW1lcywgYnV0IG1vc3Qgc3lzdGVt IHV0aWxpdGllcwo+Pj4gICAgIHRyYW5zbGF0ZSB0aGVtIGJhY2sgdG8gdGhlIC9kZXYvbWFwcGVy LyBuYW1lcyBhbmQgdGh1cyBjb25mdXNlIHZhcmlvdXMgdGVzdAo+Pj4gICAgIGNhc2VzLiAgQWRk IHN1cHBvcnQgdG8gX2lzX2Jsb2NrX2RldiB0byByZWFkIHN5bWxpbmtzLCBhbmQgYWRkIGRvY3Vt ZW50YXRpb24KPj4+ICAgICBvbiBob3cgdG8gcnVuIHhmc3Rlc3RzIG9uIGRldmljZSBtYXBwZXIg dm9sdW1lcy4KPj4+Cj4+PiAgICAgU2lnbmVkLW9mZi1ieTogQ2hyaXN0b3BoIEhlbGx3aWcgPGhj aEBsc3QuZGU+Cj4+PiAgICAgUmV2aWV3ZWQtYnk6IEFsZXggRWxkZXIgPGFlbGRlckBzZ2kuY29t Pgo+Pj4KPj4+IENoZWVycywKPj4+Cj4+PiBEYXZlLgo+Pj4KPj4KPj4gUmVjZW50ICJyZWFscGF0 aCIgY2hhbmdlcyBhbHNvIHdlbnQgaW46Cj4+Cj4+IGIwM2M2NjIzOTk5NTY2MDk5MzRmZjA2M2U5 MDY0ZTE1ZGM3NDU5YWMgeGZzdGVzdHM6IGZpeCB0byBidWlsZCBzcmMvcmVhbHBhdGggYW5kIHRo ZSBjb3JyZWN0IHRoZSBleGlzdGVuY2Ugb2YgdGFyZ2V0IGRldmljZXMKPj4gZDVlYTg3M2ZjYmYw MGI4NDFmMDUxMWEyNmZiMzQxMzY0YTVjNjQyNSB4ZnN0ZXN0czogcmVzb2x2ZSBzeW1saW5rZWQg ZGV2aWNlcyB0byByZWFsIHBhdGhzCj4+Cj4+IHNvIGVpdGhlciBvZiB0aG9zZSBjb3VsZCBoYXZl IGJyb2tlbiBhbmQvb3IgZml4ZWQgaXQgZm9yIHlvdSA6KQo+IAo+IFl1cCwgdGhvc2UgYXJlIGFs bW9zdCBjZXJ0YWlubHkgdGhlIHBhdGNoZXMgdGhhdCBicm9rZSBkZXZpY2UgbWFwcGVyCj4gc3Vw cG9ydC4gVGhlcmUnIGFyZW4ndCBjaGFuZ2VzIHRvIGNvbW1vbi5yYywgc28gSSBkaWRuJ3Qgbm90 aWNlIHRoZW0uCj4gVGhleSBiYXNpY2FsbHkgb3ZlcnJpZGUgdGhlIGZpeCB0aGF0IENocmlzdG9w aCBtYWRlIHRvIHN1cHBvcnQKPiAvZGV2L21hcHBlciBsaW5rcyBwcm9wZXJseS4KPiAKPiBJJ2Qg c3VnZ2VzdCBhIHJldmVydCBpcyBpbiBvcmRlciwgdGhlIHR3byBwYXRjaGVzIGFib3ZlIHdlcmUg cGFydAo+IG9mIFJpY2gncyBob3ZlcmluZyBvZiBvbGQsIHVucmV2aWV3ZWQgcGF0Y2hlcy4gVGhp cyBwcm9ibGVtIHdhcwo+IGFscmVhZHkgZml4ZWQgaW4gYSBkaWZmZXJlbnQgd2F5IGJ5IENocmlz dG9waCwgc28gYWRkaW5nIHRoZXNlCj4gcGF0Y2hlcyB3YXMgd3JvbmcuCgpGaW5lIHdpdGggbWUg Li4uCgpSeWFuLCBjYW4geW91IHRlc3Qgdy9vIHRob3NlLCBhbmQgaWYgaXQgd29ya3MgLQoKUmlj aCwgY2FuIHlvdSByZXZlcnQgdGhvc2UgcGxlYXNlPwoKLUVyaWMKCj4gQ2hlZXJzLAo+IAo+IERh dmUuCj4gCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwp4 ZnMgbWFpbGluZyBsaXN0Cnhmc0Bvc3Muc2dpLmNvbQpodHRwOi8vb3NzLnNnaS5jb20vbWFpbG1h bi9saXN0aW5mby94ZnMK