From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([208.118.235.92]:43161) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdSdz-0000zi-Fb for qemu-devel@nongnu.org; Tue, 27 Nov 2012 16:24:40 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TdSdt-0006Xs-JW for qemu-devel@nongnu.org; Tue, 27 Nov 2012 16:24:39 -0500 Received: from v220110690675601.yourvserver.net ([78.47.199.172]:46289) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TdSdt-0006XA-CG for qemu-devel@nongnu.org; Tue, 27 Nov 2012 16:24:33 -0500 Message-ID: <50B52F8E.70406@weilnetz.de> Date: Tue, 27 Nov 2012 22:24:30 +0100 From: Stefan Weil MIME-Version: 1.0 References: <1354047085-12401-1-git-send-email-brogers@suse.com> <20121127205430.GA7962@vm> In-Reply-To: <20121127205430.GA7962@vm> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] qapi: fix qapi_dealloc_type_size parameter type List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: mdroth Cc: qemu-devel@nongnu.org, stefanha@redhat.com, Bruce Rogers Am 27.11.2012 21:54, schrieb mdroth: > On Tue, Nov 27, 2012 at 01:11:25PM -0700, Bruce Rogers wrote: >> The second parameter to qapi_dealloc_type_size should be a uint64_t *, >> not a size_t *. This was causing our 32 bit x86 build to fail, since >> warnings are treated as errors. >> >> Signed-off-by: Bruce Rogers > Doh, I should've caught this in review. Yes, qapi's type generator uses > uint64_t as the underlying type for 'size', and the visitor interface > calls for uint64_t*, so that's what the implementation should use. > > Reviewed-by: Michael Roth I have sent a similar patch this morning but just noticed that I forgot to cc qemu-devel. Only Stefan H. and Anthony got it :-( Anthony, as Bruce' patch was already reviewed, please commit this one instead of my patch. Reviewed-by: Stefan Weil >> --- >> qapi/qapi-dealloc-visitor.c | 2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) >> >> diff --git a/qapi/qapi-dealloc-visitor.c b/qapi/qapi-dealloc-visitor.c >> index a07b171..75214e7 100644 >> --- a/qapi/qapi-dealloc-visitor.c >> +++ b/qapi/qapi-dealloc-visitor.c >> @@ -132,7 +132,7 @@ static void qapi_dealloc_type_number(Visitor *v, double *obj, const char *name, >> { >> } >> >> -static void qapi_dealloc_type_size(Visitor *v, size_t *obj, const char *name, >> +static void qapi_dealloc_type_size(Visitor *v, uint64_t *obj, const char *name, >> Error **errp) >> { >> } >> -- >> 1.7.7 >>