From: Eric Sandeen <sandeen@redhat.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: test EROFS vs. EEXIST when creating on an RO filesystem
Date: Tue, 27 Nov 2012 16:12:58 -0600 [thread overview]
Message-ID: <50B53AEA.3080102@redhat.com> (raw)
In-Reply-To: <20121127221111.GA13753@infradead.org>
On 11/27/12 4:11 PM, Christoph Hellwig wrote:
> On Tue, Nov 27, 2012 at 03:16:39PM -0600, Eric Sandeen wrote:
>> TBH, I don't know if this is posix-specified, but I found out the
>> hard way that when trying to re-create existing files on a readonly
>> filesystem, some apps expect/handle EEXIST, but fail on EROFS.
>>
>> This will test mkdir, mknod, and symlinks for that behavior.
>
> Just curious, which filesystem would fail this currently or did in the
> past?
No single filesystem, really -
I temporarily broke the VFS in a rhel backport. ;) But it seems like
the kind of thing that could be missed in the future, so figured it was
worth a quick test.
(basically this was from moving mnt_want_write outside i_mutex for freeze
work, and returning an error directly from mnt_want_write() would
give us EROFS instead of maybe EEXIST)
-Eric
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2012-11-27 22:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-27 21:16 [PATCH] xfstests: test EROFS vs. EEXIST when creating on an RO filesystem Eric Sandeen
2012-11-27 22:08 ` Dave Chinner
2012-11-27 22:10 ` Eric Sandeen
2012-11-27 22:11 ` Christoph Hellwig
2012-11-27 22:12 ` Eric Sandeen [this message]
2012-11-27 22:19 ` Christoph Hellwig
2012-11-28 3:19 ` [PATCH V2] " Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50B53AEA.3080102@redhat.com \
--to=sandeen@redhat.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.